You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org> on 2026/10/28 10:22:50 UTC
[Impala-ASF-CR] IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/25220
Change subject: IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
......................................................................
IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
OPTIMIZE is now supported with Iceberg REST catalog in Impala.
OptimizeStmt now passes the analysis-time check and
IcebergDmlFinalizer accepts OPTIMIZE.
The transaction commit path was already shared with catalogd.
Testing:
- Updated IcebergRestDmlOperationTest and AnalyzerCapabilityTest.
- New iceberg-rest-optimize.test and test_rest_catalog_optimize,
including commit failure and concurrent INSERT/DELETE conflicts.
Change-Id: I3e98b256d1bcba2075669553ae3e4b2c9519c270
Assisted-by: Claude Opus 5.5 (Claude Code)
---
M docs/topics/impala_iceberg_rest_catalog.xml
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/service/IcebergDmlFinalizer.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerCapabilityTest.java
M fe/src/test/java/org/apache/impala/service/IcebergRestDmlOperationTest.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-optimize.test
M tests/common/iceberg_rest_test_tables.py
M tests/custom_cluster/test_iceberg_rest_catalog.py
10 files changed, 523 insertions(+), 20 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/25220/2
--
To view, visit http://gerrit.cloudera.org:8080/25220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3e98b256d1bcba2075669553ae3e4b2c9519c270
Gerrit-Change-Number: 25220
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/25220 )
Change subject: IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
......................................................................
IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
OPTIMIZE is now supported with Iceberg REST catalog in Impala.
OptimizeStmt now passes the analysis-time check and
IcebergDmlFinalizer accepts OPTIMIZE.
The transaction commit path was already shared with catalogd.
Testing:
- Updated IcebergRestDmlOperationTest and AnalyzerCapabilityTest.
- New iceberg-rest-optimize.test and test_rest_catalog_optimize,
including commit failure and concurrent INSERT/DELETE conflicts.
Change-Id: I3e98b256d1bcba2075669553ae3e4b2c9519c270
Assisted-by: Claude Opus 5.5 (Claude Code)
---
M docs/topics/impala_iceberg_rest_catalog.xml
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/service/IcebergDmlFinalizer.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerCapabilityTest.java
M fe/src/test/java/org/apache/impala/service/IcebergRestDmlOperationTest.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-optimize.test
M tests/common/iceberg_rest_test_tables.py
M tests/custom_cluster/test_iceberg_rest_catalog.py
10 files changed, 519 insertions(+), 22 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/20/25220/3
--
To view, visit http://gerrit.cloudera.org:8080/25220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3e98b256d1bcba2075669553ae3e4b2c9519c270
Gerrit-Change-Number: 25220
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
[Impala-ASF-CR] IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25220 )
Change subject: IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/25220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e98b256d1bcba2075669553ae3e4b2c9519c270
Gerrit-Change-Number: 25220
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Oct 2026 19:02:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/25220 )
Change subject: IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14358/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/25220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e98b256d1bcba2075669553ae3e4b2c9519c270
Gerrit-Change-Number: 25220
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Oct 2026 14:33:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
Posted by "Nandor Kollar (Code Review)" <ge...@cloudera.org>.
Nandor Kollar has posted comments on this change. ( http://gerrit.cloudera.org:8080/25220 )
Change subject: IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/25220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e98b256d1bcba2075669553ae3e4b2c9519c270
Gerrit-Change-Number: 25220
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Wed, 28 Oct 2026 12:49:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/25220 )
Change subject: IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
......................................................................
Patch Set 3:
(1 comment)
Thanks for the reviews!
I rebased after the MERGE patch and the OPTIMIZE PARTITION support. I did not include tests for the latter, I thought that once we support DDLs it will be easier by sharing the existing ones. But I am open to adding if you think it is important.
http://gerrit.cloudera.org:8080/#/c/25220/2/tests/custom_cluster/test_iceberg_rest_catalog.py
File tests/custom_cluster/test_iceberg_rest_catalog.py:
http://gerrit.cloudera.org:8080/#/c/25220/2/tests/custom_cluster/test_iceberg_rest_catalog.py@485
PS2, Line 485: t s
> nit: It could be == 1
Done
--
To view, visit http://gerrit.cloudera.org:8080/25220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e98b256d1bcba2075669553ae3e4b2c9519c270
Gerrit-Change-Number: 25220
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Oct 2026 14:22:10 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/25220 )
Change subject: IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
......................................................................
Patch Set 3: Code-Review+2
Nice work! I think we are good with iceberg-rest-optimize.test for now.
--
To view, visit http://gerrit.cloudera.org:8080/25220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e98b256d1bcba2075669553ae3e4b2c9519c270
Gerrit-Change-Number: 25220
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Fri, 30 Oct 2026 14:33:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
Posted by "Peter Rozsa (Code Review)" <ge...@cloudera.org>.
Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/25220 )
Change subject: IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/25220/2/tests/custom_cluster/test_iceberg_rest_catalog.py
File tests/custom_cluster/test_iceberg_rest_catalog.py:
http://gerrit.cloudera.org:8080/#/c/25220/2/tests/custom_cluster/test_iceberg_rest_catalog.py@485
PS2, Line 485: > 0
nit: It could be == 1
--
To view, visit http://gerrit.cloudera.org:8080/25220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3e98b256d1bcba2075669553ae3e4b2c9519c270
Gerrit-Change-Number: 25220
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>
Gerrit-Comment-Date: Thu, 29 Oct 2026 14:50:43 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/25220 )
Change subject: IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
......................................................................
IMPALA-15498: Support OPTIMIZE on Iceberg REST catalog tables
OPTIMIZE is now supported with Iceberg REST catalog in Impala.
OptimizeStmt now passes the analysis-time check and
IcebergDmlFinalizer accepts OPTIMIZE.
The transaction commit path was already shared with catalogd.
Testing:
- Updated IcebergRestDmlOperationTest and AnalyzerCapabilityTest.
- New iceberg-rest-optimize.test and test_rest_catalog_optimize,
including commit failure and concurrent INSERT/DELETE conflicts.
Change-Id: I3e98b256d1bcba2075669553ae3e4b2c9519c270
Assisted-by: Claude Opus 5.5 (Claude Code)
Reviewed-on: http://gerrit.cloudera.org:8080/25220
Reviewed-by: Peter Rozsa <pr...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_iceberg_rest_catalog.xml
M fe/src/main/java/org/apache/impala/analysis/Analyzer.java
M fe/src/main/java/org/apache/impala/analysis/OptimizeStmt.java
M fe/src/main/java/org/apache/impala/catalog/FeIcebergTable.java
M fe/src/main/java/org/apache/impala/service/IcebergDmlFinalizer.java
M fe/src/test/java/org/apache/impala/analysis/AnalyzerCapabilityTest.java
M fe/src/test/java/org/apache/impala/service/IcebergRestDmlOperationTest.java
A testdata/workloads/functional-query/queries/QueryTest/iceberg-rest-optimize.test
M tests/common/iceberg_rest_test_tables.py
M tests/custom_cluster/test_iceberg_rest_catalog.py
10 files changed, 519 insertions(+), 22 deletions(-)
Approvals:
Peter Rozsa: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/25220
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3e98b256d1bcba2075669553ae3e4b2c9519c270
Gerrit-Change-Number: 25220
Gerrit-PatchSet: 4
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Nandor Kollar <ko...@gmail.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Peter Rozsa <pr...@cloudera.com>