[GitHub] ivankelly commented on a change in pull request #1367: Rest endpoint for triggering compaction

[GitBox <gi...@apache.org>]

ivankelly commented on a change in pull request #1367: Rest endpoint for triggering compaction
URL: https://github.com/apache/incubator-pulsar/pull/1367#discussion_r175992187
 
 

 ##########
 File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerServiceException.java
 ##########
 @@ -139,6 +139,12 @@ public TooManyRequestsException(String msg) {
         }
     }
 
+    public static class AlreadyRunningException extends BrokerServiceException {
 
 Review comment:
   If you get the exception when trying to run compaction, it's not ambiguous. I left it generic because I thought it could be used for other cases also. I've not problem changing it to CompactionAlreadyRunningException though.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services