You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2020/12/14 19:20:56 UTC

[commons-logging] branch master updated: Fix build for GitHub

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-logging.git


The following commit(s) were added to refs/heads/master by this push:
     new 33c33e6  Fix build for GitHub
33c33e6 is described below

commit 33c33e6b8014e4281a6359f0a4d846101290502d
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Mon Dec 14 14:20:52 2020 -0500

    Fix build for GitHub
    
    - Bump actions/checkout from v2.3.1 to v2.3.4 (#24)
    - Bump actions/setup-java from v1.4.0 to v1.4.3 (#21)
    - Add default goal with some TODOs.
---
 .github/workflows/maven.yml |  2 +-
 pom.xml                     | 17 +++++++++++++++++
 src/changes/changes.xml     |  7 +++++++
 3 files changed, 25 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
index c367e4c..ce4bb2a 100644
--- a/.github/workflows/maven.yml
+++ b/.github/workflows/maven.yml
@@ -43,4 +43,4 @@ jobs:
       with:
         java-version: ${{ matrix.java }}
     - name: Build with Maven
-      run: mvn -V --no-transfer-progress apache-rat:check spotbugs:check javadoc:javadoc -Ddoclint=all package --file pom.xml
+      run: mvn -V --no-transfer-progress -Ddoclint=all --file pom.xml
diff --git a/pom.xml b/pom.xml
index b5e523e..3b70b9b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -177,6 +177,8 @@ under the License.
   </scm>
 
   <build>
+    <!-- TODO spotbugs:check japicmp:cmp -->
+    <defaultGoal>apache-rat:check javadoc:javadoc package</defaultGoal>
     <plugins>
 
       <!--
@@ -442,6 +444,19 @@ under the License.
         </configuration>
       </plugin>
 
+      <plugin>
+        <groupId>com.github.spotbugs</groupId>
+        <artifactId>spotbugs-maven-plugin</artifactId>
+        <version>${spotbugs.plugin.version}</version>
+        <dependencies>
+          <dependency>
+            <groupId>com.github.spotbugs</groupId>
+            <artifactId>spotbugs</artifactId>
+            <version>${spotbugs.impl.version}</version>
+         </dependency>
+        </dependencies>
+      </plugin>
+
     </plugins>
   </build>
 
@@ -545,6 +560,8 @@ under the License.
     <!-- The RC version used in the staging repository URL. -->
     <commons.rc.version>RC2</commons.rc.version>
     <commons.surefire.version>2.12</commons.surefire.version>
+    <spotbugs.plugin.version>4.1.4</spotbugs.plugin.version>
+    <spotbugs.impl.version>4.2.0</spotbugs.impl.version>    
     <skipSurefireReport>true</skipSurefireReport>
     <!-- Allow default test run order to be changed -->
     <failsafe.runorder>filesystem</failsafe.runorder>
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 52fb5de..c48d716 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -50,6 +50,13 @@ The <action> type attribute can be add,update,fix,remove.
       <action issue="LOGGING-163" dev="ggregory" type="fix" due-to="Kaloyan Spiridonov">
         BufferedReader is not closed properly.
       </action>
+      <!-- UPDATES -->
+      <action dev="ggregory" type="update" due-to="Dependabot">
+        Bump actions/checkout from v2.3.1 to v2.3.4 (#24).
+      </action>
+      <action dev="ggregory" type="update" due-to="Dependabot">
+        Bump actions/setup-java from v1.4.0 to v1.4.3 (#21).
+      </action>
     </release>
     <release version="1.2" date="2014-07-11" description="This is a maintenance release containing bug fixes. Java 1.2 or later is required.">
       <action issue="LOGGING-37" dev="tn" type="fix" due-to="Matthias Ernst,Archie Cobbs">