You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/15 07:52:23 UTC

[GitHub] [spark] MaxGekk commented on a change in pull request #32176: [WIP][SPARK-35076][SQL] Parse interval literals as ANSI intervals

MaxGekk commented on a change in pull request #32176:
URL: https://github.com/apache/spark/pull/32176#discussion_r613837850



##########
File path: sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/SparkThriftServerProtocolVersionsSuite.scala
##########
@@ -362,11 +362,13 @@ class SparkThriftServerProtocolVersionsSuite extends HiveThriftServer2TestBase {
     }
 
     test(s"$version get interval type") {
-      testExecuteStatementWithProtocolVersion(version, "SELECT interval '1' year '2' day") { rs =>
+      testExecuteStatementWithProtocolVersion(
+        version,
+        "SELECT CAST('1 year 2 day' AS INTERVAL) AS icol") { rs =>

Review comment:
       I wasn't able to set the config in the test. So, have to use the Cast expression to get the legacy interval column.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org