You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/11/20 03:27:23 UTC
[GitHub] [rocketmq-client-go] gaoyf opened a new pull request #559: when no msg or offset not match correct local offset.
gaoyf opened a new pull request #559:
URL: https://github.com/apache/rocketmq-client-go/pull/559
ref #555
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-io commented on pull request #559: when no msg or offset not match correct local offset.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #559:
URL: https://github.com/apache/rocketmq-client-go/pull/559#issuecomment-745128619
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=h1) Report
> Merging [#559](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=desc) (9f6e56f) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/e1d9be806c182c142aee212eab27e413705f4e79?el=desc) (e1d9be8) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #559 +/- ##
==========================================
- Coverage 24.21% 24.19% -0.02%
==========================================
Files 48 48
Lines 5010 5018 +8
==========================================
+ Hits 1213 1214 +1
- Misses 3598 3605 +7
Partials 199 199
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/559/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `11.35% <0.00%> (+0.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=footer). Last update [e1d9be8...9f6e56f](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] ingtube-zhangkun commented on pull request #559: when no msg or offset not match correct local offset.
Posted by GitBox <gi...@apache.org>.
ingtube-zhangkun commented on pull request #559:
URL: https://github.com/apache/rocketmq-client-go/pull/559#issuecomment-755038269
consumingMsgOrderlyTreeMap may be not empty !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] xujianhai666 commented on a change in pull request #559: when no msg or offset not match correct local offset.
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on a change in pull request #559:
URL: https://github.com/apache/rocketmq-client-go/pull/559#discussion_r535077817
##########
File path: consumer/push_consumer.go
##########
@@ -692,6 +692,7 @@ func (pc *pushConsumer) pullMessage(request *PullRequest) {
case primitive.PullNoNewMsg:
rlog.Debug(fmt.Sprintf("Topic: %s, QueueId: %d no more msg, current offset: %d, next offset: %d",
Review comment:
I found that u should correct next offset
```
case NO_NEW_MSG:
pullRequest.setNextOffset(pullResult.getNextBeginOffset());
DefaultMQPushConsumerImpl.this.correctTagsOffset(pullRequest);
DefaultMQPushConsumerImpl.this.executePullRequestImmediately(pullRequest);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] qianlongzt commented on pull request #559: when no msg or offset not match correct local offset.
Posted by GitBox <gi...@apache.org>.
qianlongzt commented on pull request #559:
URL: https://github.com/apache/rocketmq-client-go/pull/559#issuecomment-793423722
可以合并吗？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-io edited a comment on pull request #559: when no msg or offset not match correct local offset.
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #559:
URL: https://github.com/apache/rocketmq-client-go/pull/559#issuecomment-745128619
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=h1) Report
> Merging [#559](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=desc) (9f6e56f) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/e1d9be806c182c142aee212eab27e413705f4e79?el=desc) (e1d9be8) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #559 +/- ##
==========================================
- Coverage 24.21% 24.19% -0.02%
==========================================
Files 48 48
Lines 5010 5018 +8
==========================================
+ Hits 1213 1214 +1
- Misses 3598 3605 +7
Partials 199 199
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [consumer/push\_consumer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/559/diff?src=pr&el=tree#diff-Y29uc3VtZXIvcHVzaF9jb25zdW1lci5nbw==) | `11.35% <0.00%> (+0.01%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=footer). Last update [e1d9be8...9f6e56f](https://codecov.io/gh/apache/rocketmq-client-go/pull/559?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] qianlongzt commented on a change in pull request #559: when no msg or offset not match correct local offset.
Posted by GitBox <gi...@apache.org>.
qianlongzt commented on a change in pull request #559:
URL: https://github.com/apache/rocketmq-client-go/pull/559#discussion_r592183853
##########
File path: consumer/push_consumer.go
##########
@@ -715,7 +717,12 @@ func (pc *pushConsumer) pullMessage(request *PullRequest) {
}
func (pc *pushConsumer) correctTagsOffset(pr *PullRequest) {
- // TODO
+ if pr.pq.cachedMsgCount == 0 {
Review comment:
```suggestion
if atomic.LoadInt64(&pr.pq.cachedMsgCount) == 0 {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] qianlongzt edited a comment on pull request #559: when no msg or offset not match correct local offset.
Posted by GitBox <gi...@apache.org>.
qianlongzt edited a comment on pull request #559:
URL: https://github.com/apache/rocketmq-client-go/pull/559#issuecomment-793423722
any update？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] qianlongzt commented on pull request #559: when no msg or offset not match correct local offset.
Posted by GitBox <gi...@apache.org>.
qianlongzt commented on pull request #559:
URL: https://github.com/apache/rocketmq-client-go/pull/559#issuecomment-800243143
cachedMsgCount should alway use by atomic
https://github.com/ingtube/rocketmq-client-go/commit/1864f166a2fa82c02816accf04d175094764c3c3
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] qianlongzt commented on a change in pull request #559: when no msg or offset not match correct local offset.
Posted by GitBox <gi...@apache.org>.
qianlongzt commented on a change in pull request #559:
URL: https://github.com/apache/rocketmq-client-go/pull/559#discussion_r595149832
##########
File path: consumer/push_consumer.go
##########
@@ -715,7 +717,12 @@ func (pc *pushConsumer) pullMessage(request *PullRequest) {
}
func (pc *pushConsumer) correctTagsOffset(pr *PullRequest) {
- // TODO
+ if atomic.LoadInt64(&pr.pq.cachedMsgCount) == 0 {
Review comment:
check more
```suggestion
if atomic.LoadInt64(&pr.pq.cachedMsgCount) == 0 {
if pr.pq.IsDroppd() {
return
}
if !pr.pq.IsLock() {
return
}
if pr.pq.isLockExpired() {
return
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org