[GitHub] [activemq-artemis] jbertram commented on pull request #4040: OpenWireMessageConverter - Allow binary deserialization of existing message properties

[GitBox <gi...@apache.org>]

jbertram commented on PR #4040:
URL: https://github.com/apache/activemq-artemis/pull/4040#issuecomment-1106688943

   > So if those properties are not needed by the OpenWire clients this could be ignored, but I feel it is still not the greatest way just to ignore. The data was written with an older version and now it is not recognized anymore. 
   
   I didn't mean to imply that we ignore the warning messages (although it's safe to ignore in almost all circumstances). I was simply trying to understand your statement that the message "could not be deliverd" as that did not fit with my understanding of that code.
   
   > IMHO bad practice for a data broker.
   
   Agreed. This was an oversight in the changes from [ARTEMIS-3698](https://issues.apache.org/jira/browse/ARTEMIS-3698).
   
   > So I can/should create an Jira issue? 
   
   Yes.
   
   > Anything I need to consider when filling out the fields?
   
   No. Just fill out the title and the description. The defaults should be fine for everything else.
   
   Thanks!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org