[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #4050: [WIP] Add FileIOMetrics to enable reporting of read/write metrics

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #4050:
URL: https://github.com/apache/iceberg/pull/4050#discussion_r801970593



##########
File path: aws/src/main/java/org/apache/iceberg/aws/s3/S3InputStream.java
##########
@@ -81,6 +89,8 @@ public int read() throws IOException {
 
     pos += 1;
     next += 1;
+    readBytes.increment(1L);

Review comment:
       Do we want to update the metrics every time here? This feels like it may be expensive although I obviously would want to check benchmarks to be sure. I think a lot of systems tend to just update metrics every X operations and then do a final update in the "close" method




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org