You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/09/11 13:58:59 UTC

[GitHub] [nifi] bbende commented on a change in pull request #4519: NIFI-7799: Relogin with Kerberos on connect exception in DBCPConnectionPool

bbende commented on a change in pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#discussion_r487063820



##########
File path: nifi-mock/pom.xml
##########
@@ -58,6 +58,11 @@
             <artifactId>nifi-data-provenance-utils</artifactId>
             <version>1.13.0-SNAPSHOT</version>
         </dependency>
+        <dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-kerberos-credentials-service-api</artifactId>
+            <version>1.13.0-SNAPSHOT</version>
+        </dependency>

Review comment:
       I lean towards `nifi-mock `only really providing mocks for things in `nifi-api `and `nifi-framework-api`, but not really for extensions related things like a controller service api. 
   
   I can see the need to have shared mock impls for controller services though, maybe a new test utils module under `nifi-nar-bundles/nifi-extension-utils`? 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org