You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2019/05/05 15:25:59 UTC

[GitHub] [skywalking] flycash opened a new pull request #2593: Using PowerMockito to mock System.getent;

flycash opened a new pull request #2593: Using PowerMockito to mock System.getent;
URL: https://github.com/apache/skywalking/pull/2593
 
 
   Now, I read the document of PowerMockito and find the way to mock system class's static method.
   So I remove the reflection code. I think it would be better to use PowerMockito and it can avoid the problem of compatability between difference OS and platform.
   
   see [EnvUtilsTest failed](https://github.com/apache/skywalking/pull/2570)
   
   - Why submit this pull request?
   - [X] Bug fix
   - [ ] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   ___
   ### Bug fix
   - Bug description.
   
   - How to fix?
   
   ___
   ### New feature or improvement
   - Describe the details and related test reports.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services