You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "XComp (via GitHub)" <gi...@apache.org> on 2023/04/12 17:21:08 UTC

[GitHub] [flink] XComp commented on a diff in pull request #22317: [FLINK-29334][runtime] Remove releaseAndTryRemoveAll in StateHandleStore

XComp commented on code in PR #22317:
URL: https://github.com/apache/flink/pull/22317#discussion_r1164423432


##########
flink-runtime/src/test/java/org/apache/flink/runtime/persistence/TestingStateHandleStore.java:
##########
@@ -121,11 +121,6 @@ public boolean releaseAndTryRemove(String name) throws Exception {
         return removeFunction.apply(name);
     }
 
-    @Override
-    public void releaseAndTryRemoveAll() throws Exception {
-        removeAllRunnable.run();

Review Comment:
   `removeAllRunnable` can be removed entirely



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org