You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/11/10 18:25:03 UTC

[GitHub] [lucene] uschindler opened a new pull request, #11918: Port generic exception handling from MemorySegmentIndexInput to ByteBufferIndexInput

uschindler opened a new pull request, #11918:
URL: https://github.com/apache/lucene/pull/11918

   This also adds incorrect (e.g., negative) positions to exception message.
   
   This also fixes some wrong exception messages (seek vs. read) in ByteBufferIndexInput. Sometimes it said "seek" although it should say "read". In MemorySegmentIndexInput I already fixed this last year.
   
   This closes #11912.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] rmuir commented on pull request #11918: Port generic exception handling from MemorySegmentIndexInput to ByteBufferIndexInput

Posted by GitBox <gi...@apache.org>.
rmuir commented on PR #11918:
URL: https://github.com/apache/lucene/pull/11918#issuecomment-1311107401

   yes, +1 to backport. This way if there is another problem, it might be easier to debug.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] uschindler merged pull request #11918: Port generic exception handling from MemorySegmentIndexInput to ByteBufferIndexInput

Posted by GitBox <gi...@apache.org>.
uschindler merged PR #11918:
URL: https://github.com/apache/lucene/pull/11918


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] uschindler commented on pull request #11918: Port generic exception handling from MemorySegmentIndexInput to ByteBufferIndexInput

Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #11918:
URL: https://github.com/apache/lucene/pull/11918#issuecomment-1311649830

   @jpountz Do you want to do a review, otherwise I will merge this later this afternoon?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] uschindler commented on pull request #11918: Port generic exception handling from MemorySegmentIndexInput to ByteBufferIndexInput

Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #11918:
URL: https://github.com/apache/lucene/pull/11918#issuecomment-1310991790

   Ah you added milestone 9.4.2 already to issue. Will do same here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] uschindler commented on pull request #11918: Port generic exception handling from MemorySegmentIndexInput to ByteBufferIndexInput

Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #11918:
URL: https://github.com/apache/lucene/pull/11918#issuecomment-1310952543

   Should I backport this also to 9.4.2 when it gets released next week. I am afraid of more horrible bugs in vectors and I'd like to give people a chance to report it.
   
   Problem of Elasticsearch is (LOL): they did not enable `--enable-preview`, so they did not get good exception messages (for that I have a solution where I will come with a PR soon, which enables MemorySegment support without `--enable-preview` by some tricks).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org

[GitHub] [lucene] uschindler commented on pull request #11918: Port generic exception handling from MemorySegmentIndexInput to ByteBufferIndexInput

Posted by GitBox <gi...@apache.org>.
uschindler commented on PR #11918:
URL: https://github.com/apache/lucene/pull/11918#issuecomment-1310726064

   The new test is a bit bad, but unfortunately, MMapDirectory's multi-input only has an assert in seek(). If that hits, test also passses. In reality negative offsets on slices should also throw correct exception.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org