You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2012/09/15 02:11:07 UTC
[jira] [Created] (HDFS-3939) Some NN#getNameNodeAddress cleanup
Eli Collins created HDFS-3939:
---------------------------------
Summary: Some NN#getNameNodeAddress cleanup
Key: HDFS-3939
URL: https://issues.apache.org/jira/browse/HDFS-3939
Project: Hadoop HDFS
Issue Type: Improvement
Components: name-node
Affects Versions: 2.0.0-alpha
Reporter: Eli Collins
Assignee: Eli Collins
Priority: Minor
Attachments: hdfs-3939.txt
Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3939) NN RPC address cleanup
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457826#comment-13457826 ]
Daryn Sharp commented on HDFS-3939:
-----------------------------------
+1 Looks like simple enough changes. You might consider breaking out the {{NNRpcServer#join}} change to another jira but they are a few pretty simple lines so it's up to you.
> NN RPC address cleanup
> ----------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hdfs-3939.txt, hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3939) NN RPC address cleanup
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457996#comment-13457996 ]
Hudson commented on HDFS-3939:
------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #2806 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/2806/])
HDFS-3939. NN RPC address cleanup. Contributed by Eli Collins (Revision 1387278)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1387278
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileChecksumServlets.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/corrupt_files.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfsnodelist.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
> NN RPC address cleanup
> ----------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: hdfs-3939.txt, hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3939) NN RPC address cleanup
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458002#comment-13458002 ]
Hudson commented on HDFS-3939:
------------------------------
Integrated in Hadoop-Common-trunk-Commit #2743 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/2743/])
HDFS-3939. NN RPC address cleanup. Contributed by Eli Collins (Revision 1387278)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1387278
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileChecksumServlets.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/corrupt_files.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfsnodelist.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
> NN RPC address cleanup
> ----------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: hdfs-3939.txt, hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3939) Some NN#getNameNodeAddress cleanup
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-3939:
------------------------------
Status: Patch Available (was: Open)
> Some NN#getNameNodeAddress cleanup
> ----------------------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3939) NN RPC address cleanup
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457289#comment-13457289 ]
Hadoop QA commented on HDFS-3939:
---------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545453/hdfs-3939.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in hadoop-hdfs-project/hadoop-hdfs.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3198//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3198//console
This message is automatically generated.
> NN RPC address cleanup
> ----------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hdfs-3939.txt, hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3939) NN RPC address cleanup
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-3939:
------------------------------
Summary: NN RPC address cleanup (was: Some NN#getNameNodeAddress cleanup)
> NN RPC address cleanup
> ----------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hdfs-3939.txt, hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3939) Some NN#getNameNodeAddress cleanup
Posted by "Daryn Sharp (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457008#comment-13457008 ]
Daryn Sharp commented on HDFS-3939:
-----------------------------------
+1 Assuming test failure is unrelated (I think it is)
> Some NN#getNameNodeAddress cleanup
> ----------------------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3939) Some NN#getNameNodeAddress cleanup
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-3939:
------------------------------
Attachment: hdfs-3939.txt
Thanks Daryn! Yes the test failure is unrelated (HDFS-3931).
Updated patch with a little more cleanup. Mind taking another look?
- Make client/service RPC "up at" logs consistent
- Cleanup get*Address javadocs
- In NN startup we overwrite fs.defaultFS using the RPC addr, INFO log that
- Cleanup RPC.Builder formatting in NNRpcServer
- NNRpcServer#join should also join on serviceRpcServer
> Some NN#getNameNodeAddress cleanup
> ----------------------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hdfs-3939.txt, hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3939) Some NN#getNameNodeAddress cleanup
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-3939:
------------------------------
Attachment: hdfs-3939.txt
Patch attached.
> Some NN#getNameNodeAddress cleanup
> ----------------------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3939) Some NN#getNameNodeAddress cleanup
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456289#comment-13456289 ]
Hadoop QA commented on HDFS-3939:
---------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12545250/hdfs-3939.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 1 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests in hadoop-hdfs-project/hadoop-hdfs:
org.apache.hadoop.hdfs.TestDatanodeBlockScanner
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/3194//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/3194//console
This message is automatically generated.
> Some NN#getNameNodeAddress cleanup
> ----------------------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Attachments: hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HDFS-3939) NN RPC address cleanup
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-3939:
------------------------------
Resolution: Fixed
Fix Version/s: 2.0.3-alpha
Target Version/s: (was: 2.0.3-alpha)
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
I've committed this and merged to branch-2.
> NN RPC address cleanup
> ----------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: hdfs-3939.txt, hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3939) NN RPC address cleanup
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458035#comment-13458035 ]
Hudson commented on HDFS-3939:
------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #2766 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/2766/])
HDFS-3939. NN RPC address cleanup. Contributed by Eli Collins (Revision 1387278)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1387278
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileChecksumServlets.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/corrupt_files.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfsnodelist.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
> NN RPC address cleanup
> ----------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: hdfs-3939.txt, hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3939) NN RPC address cleanup
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458697#comment-13458697 ]
Hudson commented on HDFS-3939:
------------------------------
Integrated in Hadoop-Mapreduce-trunk #1201 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1201/])
HDFS-3939. NN RPC address cleanup. Contributed by Eli Collins (Revision 1387278)
Result = SUCCESS
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1387278
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileChecksumServlets.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/corrupt_files.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfsnodelist.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
> NN RPC address cleanup
> ----------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: hdfs-3939.txt, hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HDFS-3939) NN RPC address cleanup
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-3939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13458654#comment-13458654 ]
Hudson commented on HDFS-3939:
------------------------------
Integrated in Hadoop-Hdfs-trunk #1170 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1170/])
HDFS-3939. NN RPC address cleanup. Contributed by Eli Collins (Revision 1387278)
Result = FAILURE
eli : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1387278
Files :
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileChecksumServlets.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FileDataServlet.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeJspHelper.java
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/corrupt_files.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfsnodelist.jsp
* /hadoop/common/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/MiniDFSCluster.java
> NN RPC address cleanup
> ----------------------
>
> Key: HDFS-3939
> URL: https://issues.apache.org/jira/browse/HDFS-3939
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 2.0.0-alpha
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Minor
> Fix For: 2.0.3-alpha
>
> Attachments: hdfs-3939.txt, hdfs-3939.txt
>
>
> Most callers to NN#getNameNodeAddress wrap it in NetUtils#getHostPortString or manually create the host:port string. Let's clean that up and the relevant javadocs while we're at it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira