[GitHub] marcoabreu commented on issue #9333: Temporarily disable test with failing http connection

[GitBox <gi...@apache.org>]

marcoabreu commented on issue #9333: Temporarily disable test with failing http connection
URL: https://github.com/apache/incubator-mxnet/pull/9333#issuecomment-355821133
 
 
   I personally don't like to click at randomly shortened links on the
   internet as I don't know where they are going to lead. Also, if I'm trying
   to grep for all issues in the code, this one is going to get missed. The
   meaning of the link is only available in it's context opposed to showing it
   just by looking at the link itself.
   
   Am 07.01.2018 1:54 nachm. schrieb "Kellen Sunderland" <
   notifications@github.com>:
   
   > *@KellenSunderland* commented on this pull request.
   > ------------------------------
   >
   > In R-package/tests/testthat/test_model.R
   > <https://github.com/apache/incubator-mxnet/pull/9333#discussion_r160048632>
   > :
   >
   > > @@ -172,6 +172,7 @@ test_that("Fine-tune", {
   >  })
   >
   >  test_that("Matrix Factorization", {
   > +  skip("Disabled due to an unavailible http server.  Tracked here: http://bit.ly/2qybsto")
   >
   > I'm not opposed, but can you provide some motivation for the change? I
   > shortened it to avoid line limits and maintain readability.
   >
   > ?
   > You are receiving this because you commented.
   > Reply to this email directly, view it on GitHub
   > <https://github.com/apache/incubator-mxnet/pull/9333#discussion_r160048632>,
   > or mute the thread
   > <https://github.com/notifications/unsubscribe-auth/ARxB67zHJJEPnKvsfKpmvPznbN4dSX1Bks5tIL6agaJpZM4RVdNc>
   > .
   >
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services