You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "SakulK (via GitHub)" <gi...@apache.org> on 2023/12/11 08:30:12 UTC
[PR] Use `recoverWith` instead of `recover` in `SnapshotSerializer` akka backwards compatibility [incubator-pekko]
SakulK opened a new pull request, #841:
URL: https://github.com/apache/incubator-pekko/pull/841
@pjfanning after taking another look I think this should make more sense, otherwise `snapshotFromBinary` can either return `T` or `Try[T]` (got bitten by `AnyRef` here..). I'm not sure why the previous version didn't blow up when testing this with real mongo and existing akka persistence snapshots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use `recoverWith` instead of `recover` in `SnapshotSerializer` akka backwards compatibility [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #841:
URL: https://github.com/apache/incubator-pekko/pull/841#issuecomment-1849591095
@SakulK have you tried out this change in an end to end use case? I would like to avoid making a large number of PRs here. I'm happy to change this but I would prefer to get it right this time around.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use `recoverWith` instead of `recover` in `SnapshotSerializer` akka backwards compatibility [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #841:
URL: https://github.com/apache/incubator-pekko/pull/841
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Use `recoverWith` instead of `recover` in `SnapshotSerializer` akka backwards compatibility [incubator-pekko]
Posted by "SakulK (via GitHub)" <gi...@apache.org>.
SakulK commented on PR #841:
URL: https://github.com/apache/incubator-pekko/pull/841#issuecomment-1849830678
@pjfanning yes, this works for me end-to-end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org