[jira] [Commented] (IMPALA-9732) Improve exceptions of unsupported HdfsTableSink formats

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IMPALA-9732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17320618#comment-17320618 ] 

ASF subversion and git services commented on IMPALA-9732:
---------------------------------------------------------

Commit 6b16df9e9a4696b46b6f9c7fe2fc0aaded285623 in impala's branch refs/heads/master from Tamas Mate
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=6b16df9 ]

IMPALA-9732: Improve exceptions of unsupported HdfsTableSink formats

This change updates the exception that is thrown when the user tries to
insert into a partition which has unsupported format. The information to
make this decision is available during analysis, therefore this commit
also moves the check from the planner to the analyzer to have an
earlier result.

In the analyzer only the FeFsTables have to be checked therefore Kudu
tables are not related. Also, there is a difference between static and
dynamic partition clauses, for static partition clauses the partition
format is available during compile, for dynaminc partition clauses it is
only avaialble during runtime.

Testing:
 - Added unit tests
 - Ran exhaustive tests successfully

Change-Id: I7fa2f949336a422acb4d01c9347b9b2e808e4aec
Reviewed-on: http://gerrit.cloudera.org:8080/17300
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Improve exceptions of unsupported HdfsTableSink formats
> -------------------------------------------------------
>
>                 Key: IMPALA-9732
>                 URL: https://issues.apache.org/jira/browse/IMPALA-9732
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Frontend
>    Affects Versions: Impala 3.4.0
>            Reporter: Tamas Mate
>            Assignee: Tamas Mate
>            Priority: Major
>
> For unsupported table writes an IllegalStateException is thrown during planning [here|https://github.com/apache/impala/blame/e46bbf29d43f1d3b118933d06c63ceb135beaf9c/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java#L144]:
> {code:java}
>  Preconditions.checkState(false, "Unsupported TableSink format(s): " + Joiner.on(',').join(unsupportedFormats));
> {code}
> This exception could be improved by changing the IllegalStateException to a more meaningful one and the "TableSink format" to a term which is familiar for the users.
> Additionally, the exception is thrown generally when a table has a partition with unsupported format, dynamic partitioning is not taken into consideration. The check could be extended to only throw exception when the partition that is being written is unsupported.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org