[GitHub] [incubator-celeborn] AngersZhuuuu commented on a diff in pull request #1370: [CELEBORN-446] Support rack aware during assign slots for ROUNDROBIN

["AngersZhuuuu (via GitHub)" <gi...@apache.org>]

AngersZhuuuu commented on code in PR #1370:
URL: https://github.com/apache/incubator-celeborn/pull/1370#discussion_r1193397193


##########
common/src/main/scala/org/apache/celeborn/common/network/CelebornRackResolver.scala:
##########
@@ -46,8 +48,8 @@ class CelebornRackResolver(celebornConf: CelebornConf) extends Logging {
     }
   }
 
-  def resolve(hostName: String): String = {
-    coreResolve(Seq(hostName)).head.getNetworkLocation
+  def resolve(hostName: String): Node = {

Review Comment:
   > It's better to cache the hostName -> Node in this class to avoid resolve every time.
   
   The underline implement is `CachedDNSToSwitchMapping`, so we don't need to do this here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org