You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@devlake.apache.org by GitBox <gi...@apache.org> on 2022/11/02 03:48:37 UTC
[GitHub] [incubator-devlake-website] warren830 opened a new pull request, #310: update pr deploy time
warren830 opened a new pull request, #310:
URL: https://github.com/apache/incubator-devlake-website/pull/310
# Summary
Update pr deploy time calculation logic
### Does this close any open issues?
Closes xx
### Screenshots
Include any relevant screenshots here.
### Other Information
Any other information that is important to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] warren830 commented on a diff in pull request #310: update pr deploy time
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #310:
URL: https://github.com/apache/incubator-devlake-website/pull/310#discussion_r1012600715
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,26 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ - Find the [commits diff](the link to refdiff plugin) between two consecutive deployments by deployments' commit_sha
Review Comment:
sorry, I thought it's not ready, so i used a placer
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] klesh commented on a diff in pull request #310: update pr deploy time
Posted by GitBox <gi...@apache.org>.
klesh commented on code in PR #310:
URL: https://github.com/apache/incubator-devlake-website/pull/310#discussion_r1011223649
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,20 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
-
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ 1. Use plugin `refdiff` to calculate `refs_commits_diffs` between any two consecutive deployments under the same scope,
Review Comment:
under the same scope and environment (in terms of TESTING/STAGING/PRODUCTION)
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,20 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
-
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ 1. Use plugin `refdiff` to calculate `refs_commits_diffs` between any two consecutive deployments under the same scope,
+for example, here, we will get commit-2 and commit-3 by calculating commits_diff before deployment-1 and deployment-2,
+we can say commit-2, commit-3 and commit-4 are deployed by deployment-2
+ 2. Connect pr/mr and commits_diff through merge_commit or pr_commit, for example,
+we get pr-3 connected to commit-3
+ 3. Now we can get pr-3's deploy time by finish_time of deployment-2 minus merge_time of pr-3.
<b>Data Sources Required</b>
-This metric relies on PR/MRs collected from GitHub or GitLab.
+This metric relies on two sources:
+1. PR/MRs collected from GitHub or GitLab.
+2. CI/CD collected from Github, Gitlab or Jenkins.
Review Comment:
Similar to above
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,20 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
-
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ 1. Use plugin `refdiff` to calculate `refs_commits_diffs` between any two consecutive deployments under the same scope,
+for example, here, we will get commit-2 and commit-3 by calculating commits_diff before deployment-1 and deployment-2,
+we can say commit-2, commit-3 and commit-4 are deployed by deployment-2
+ 2. Connect pr/mr and commits_diff through merge_commit or pr_commit, for example,
+we get pr-3 connected to commit-3
+ 3. Now we can get pr-3's deploy time by finish_time of deployment-2 minus merge_time of pr-3.
<b>Data Sources Required</b>
-This metric relies on PR/MRs collected from GitHub or GitLab.
+This metric relies on two sources:
+1. PR/MRs collected from GitHub or GitLab.
Review Comment:
by enabling "Code Review" under the Data Entities section
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] Startrekzky commented on a diff in pull request #310: update pr deploy time
Posted by GitBox <gi...@apache.org>.
Startrekzky commented on code in PR #310:
URL: https://github.com/apache/incubator-devlake-website/pull/310#discussion_r1012582750
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,26 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ - Find the [commits diff](the link to refdiff plugin) between two consecutive deployments by deployments' commit_sha
+ - under the same scope and environment (in terms of TESTING/STAGING/PRODUCTION)
+for example, here, we will get commit-2 and commit-3 by calculating commits_diff before deployment-1 and deployment-2,
+we can say commit-2, commit-3 and commit-4 are deployed by deployment-2
+ - Connect pr/mr and commits_diff through merge_commit or pr_commit, for example,
+we get pr-3 connected to commit-3
+ - Now we can get pr-3's deploy time by finish_time of deployment-2 minus merge_time of pr-3.
<b>Data Sources Required</b>
-This metric relies on PR/MRs collected from GitHub or GitLab.
+This metric relies on two sources:
+1. PR/MRs collected from GitHub or GitLab by enabling "Code Review" under the Data Entities section.
+2. Deployments collected in multiple ways:
Review Comment:
Text change:
"Deployments collected in one of the following ways:"
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,26 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ - Find the [commits diff](the link to refdiff plugin) between two consecutive deployments by deployments' commit_sha
+ - under the same scope and environment (in terms of TESTING/STAGING/PRODUCTION)
+for example, here, we will get commit-2 and commit-3 by calculating commits_diff before deployment-1 and deployment-2,
+we can say commit-2, commit-3 and commit-4 are deployed by deployment-2
+ - Connect pr/mr and commits_diff through merge_commit or pr_commit, for example,
Review Comment:
Please capitalize PR/MR to make them consistent.
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,26 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ - Find the [commits diff](the link to refdiff plugin) between two consecutive deployments by deployments' commit_sha
Review Comment:
The link should be changed to 'https://devlake.apache.org/docs/Plugins/refdiff/'. I used a placeholder before.
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,26 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ - Find the [commits diff](the link to refdiff plugin) between two consecutive deployments by deployments' commit_sha
+ - under the same scope and environment (in terms of TESTING/STAGING/PRODUCTION)
+for example, here, we will get commit-2 and commit-3 by calculating commits_diff before deployment-1 and deployment-2,
Review Comment:
1. Text change:
"For example, we will get commit-2 and commit-3 by calculating commits_diff between deployment-1 and deployment-2, which means commit-2 and commit-3 are deployed by deployment-2".
2. Can we add a picture to better explain the logic?
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,26 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
Review Comment:
There's no related section about `deployment` list in 'Deployment Frequency' doc.
Text change:
`PR deploy time` is calculated by subtracting a PR's deployed_date and merged_date. Hence, we should associate PR/MRs with `deployments`.
Here are the detailed steps:
1. Find the [commits diff](the link to refdiff plugin) between two consecutive deployments by deployments' commit_sha under the same scope and environment (in terms of TESTING/STAGING/PRODUCTION)
2. ....
3. ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] warren830 commented on a diff in pull request #310: update pr deploy time
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #310:
URL: https://github.com/apache/incubator-devlake-website/pull/310#discussion_r1012603743
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,26 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ - Find the [commits diff](the link to refdiff plugin) between two consecutive deployments by deployments' commit_sha
+ - under the same scope and environment (in terms of TESTING/STAGING/PRODUCTION)
+for example, here, we will get commit-2 and commit-3 by calculating commits_diff before deployment-1 and deployment-2,
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] warren830 commented on a diff in pull request #310: update pr deploy time
Posted by GitBox <gi...@apache.org>.
warren830 commented on code in PR #310:
URL: https://github.com/apache/incubator-devlake-website/pull/310#discussion_r1012601720
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,26 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ - Find the [commits diff](the link to refdiff plugin) between two consecutive deployments by deployments' commit_sha
+ - under the same scope and environment (in terms of TESTING/STAGING/PRODUCTION)
+for example, here, we will get commit-2 and commit-3 by calculating commits_diff before deployment-1 and deployment-2,
+we can say commit-2, commit-3 and commit-4 are deployed by deployment-2
+ - Connect pr/mr and commits_diff through merge_commit or pr_commit, for example,
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] Startrekzky merged pull request #310: update pr deploy time
Posted by GitBox <gi...@apache.org>.
Startrekzky merged PR #310:
URL: https://github.com/apache/incubator-devlake-website/pull/310
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-devlake-website] Startrekzky commented on a diff in pull request #310: update pr deploy time
Posted by GitBox <gi...@apache.org>.
Startrekzky commented on code in PR #310:
URL: https://github.com/apache/incubator-devlake-website/pull/310#discussion_r1011288692
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,20 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
-
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ 1. Use plugin `refdiff` to calculate `refs_commits_diffs` between any two consecutive deployments under the same scope,
+for example, here, we will get commit-2 and commit-3 by calculating commits_diff before deployment-1 and deployment-2,
+we can say commit-2, commit-3 and commit-4 are deployed by deployment-2
+ 2. Connect pr/mr and commits_diff through merge_commit or pr_commit, for example,
Review Comment:
Please use a, b, c for sub-list
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,20 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
-
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ 1. Use plugin `refdiff` to calculate `refs_commits_diffs` between any two consecutive deployments under the same scope,
Review Comment:
We don't need to emphasize 'Use plugin `refdiff` to calculate `refs_commits_diffs`' as it's a user manual, just tell how it is calculated is OK.
For example:
Find the [commits diff](the link to refdiff plugin) between two consecutive deployments by deployments' commit_sha.
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,20 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
-
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ 1. Use plugin `refdiff` to calculate `refs_commits_diffs` between any two consecutive deployments under the same scope,
+for example, here, we will get commit-2 and commit-3 by calculating commits_diff before deployment-1 and deployment-2,
+we can say commit-2, commit-3 and commit-4 are deployed by deployment-2
+ 2. Connect pr/mr and commits_diff through merge_commit or pr_commit, for example,
+we get pr-3 connected to commit-3
+ 3. Now we can get pr-3's deploy time by finish_time of deployment-2 minus merge_time of pr-3.
<b>Data Sources Required</b>
-This metric relies on PR/MRs collected from GitHub or GitLab.
+This metric relies on two sources:
+1. PR/MRs collected from GitHub or GitLab.
+2. CI/CD collected from Github, Gitlab or Jenkins.
Review Comment:
2. Deployments collected in multiple ways:
- Open APIs of Jenkins, GitLab, GitHub, etc.
- Webhook for general CI tools.
- Releases and PR/MRs from GitHub, GitLab APIs, etc.
##########
docs/Metrics/LeadTimeForChanges.md:
##########
@@ -18,19 +18,22 @@ DORA dashboard. See [live demo](https://grafana-lake.demo.devlake.io/grafana/d/q
## How is it calculated?
This metric is calculated by the median cycle time of the PRs deployed in a time range. A PR's cycle time is equal to the time a PR was deployed minus the PR's first commit's authored_date.
-
+
Review Comment:
All the doc changes about `Lead Time for Changes`, including calculation method, picture and etc can be found in the 'How to Improve' part of this issue: https://github.com/apache/incubator-devlake/issues/3516
##########
docs/Metrics/LeadTimeForChanges.md:
##########
@@ -18,19 +18,22 @@ DORA dashboard. See [live demo](https://grafana-lake.demo.devlake.io/grafana/d/q
## How is it calculated?
This metric is calculated by the median cycle time of the PRs deployed in a time range. A PR's cycle time is equal to the time a PR was deployed minus the PR's first commit's authored_date.
-
+
Review Comment:
All the doc changes about `Lead Time for Changes`, including calculation method, picture and etc can be found in the 'How to Improve' part of this issue: https://github.com/apache/incubator-devlake/issues/3516
##########
docs/Metrics/DeployTime.md:
##########
@@ -16,11 +16,20 @@ The time it takes from when a PR is merged to when it is deployed.
## How is it calculated?
-You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
-
+1. You can define `deployment` based on your actual practice. For a full list of `deployment`'s definitions that DevLake support, please refer to [Deployment Frequency](/docs/Metrics/DeploymentFrequency.md).
+2. Connect pr/mr to the right `deployment`
+
+ 1. Use plugin `refdiff` to calculate `refs_commits_diffs` between any two consecutive deployments under the same scope,
+for example, here, we will get commit-2 and commit-3 by calculating commits_diff before deployment-1 and deployment-2,
+we can say commit-2, commit-3 and commit-4 are deployed by deployment-2
+ 2. Connect pr/mr and commits_diff through merge_commit or pr_commit, for example,
+we get pr-3 connected to commit-3
+ 3. Now we can get pr-3's deploy time by finish_time of deployment-2 minus merge_time of pr-3.
Review Comment:
Please refer to [issue 3516](https://github.com/apache/incubator-devlake/issues/3516), not all commits can be mapped to PRs.
##########
docs/Metrics/LeadTimeForChanges.md:
##########
@@ -18,19 +18,22 @@ DORA dashboard. See [live demo](https://grafana-lake.demo.devlake.io/grafana/d/q
## How is it calculated?
This metric is calculated by the median cycle time of the PRs deployed in a time range. A PR's cycle time is equal to the time a PR was deployed minus the PR's first commit's authored_date.
-
+
Review Comment:
All the doc changes about `Lead Time for Changes`, including calculation method, picture and etc can be found in the 'How to Improve' part of this [issue](https://github.com/apache/incubator-devlake/issues/3516) for reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@devlake.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org