You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by mm...@apache.org on 2011/05/10 00:38:40 UTC

svn commit: r1101249 - /spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/SPF.pm

Author: mmartinec
Date: Mon May  9 22:38:40 2011
New Revision: 1101249

URL: http://svn.apache.org/viewvc?rev=1101249&view=rev
Log:
Bug 6490: Mail::SpamAssassin::Plugin::SPF - Two enhancement issues - (fix a warning: "my" variable $result masks earlier declaration)

Modified:
    spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/SPF.pm

Modified: spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/SPF.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/SPF.pm?rev=1101249&r1=1101248&r2=1101249&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/SPF.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/Plugin/SPF.pm Mon May  9 22:38:40 2011
@@ -402,7 +402,7 @@ sub _check_spf {
         my $tmphdr = $1;
         if ($tmphdr =~ /^(pass|neutral|(?:hard|soft)?fail|none)(?:[^;]*?\bsmtp\.(\S+)\s*=[^;]+)?/i) {
           my $result = lc($1);
-          my $result = 'fail' if ($result eq 'hardfail'); # RFC5451 permits this.
+          $result = 'fail'  if $result eq 'hardfail';  # RFC5451 permits this
 
           my $identity = '';    # we assume it's a mfrom check if we can't tell otherwise
           if (defined $2) {