You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2019/05/29 18:22:48 UTC
Review Request 70754: Moved UPDATE_FRAMEWORK test helpers to
appropriate namespaces.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70754/
-----------------------------------------------------------
Review request for mesos, Benjamin Mahler and Meng Zhu.
Bugs: MESOS-9793
https://issues.apache.org/jira/browse/MESOS-9793
Repository: mesos
Description
-------
Moved UPDATE_FRAMEWORK test helpers to appropriate namespaces.
Diffs
-----
src/tests/master/update_framework_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/70754/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70754: Moved UPDATE_FRAMEWORK test helpers to
appropriate namespaces.
Posted by Andrei Sekretenko <as...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70754/
-----------------------------------------------------------
(Updated June 12, 2019, 4:11 p.m.)
Review request for mesos, Benjamin Mahler and Meng Zhu.
Changes
-------
Rebased.
Bugs: MESOS-9793
https://issues.apache.org/jira/browse/MESOS-9793
Repository: mesos
Description
-------
Moved UPDATE_FRAMEWORK test helpers to appropriate namespaces.
Diffs (updated)
-----
src/tests/master/update_framework_tests.cpp 78304c211c5eb9f50ea629121a6dddfe47942e9f
Diff: https://reviews.apache.org/r/70754/diff/2/
Changes: https://reviews.apache.org/r/70754/diff/1-2/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 70754: Moved UPDATE_FRAMEWORK test helpers to
appropriate namespaces.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70754/#review215809
-----------------------------------------------------------
Ship it!
Looks good, but needs a rebase (see comment on previous review)
- Benjamin Mahler
On May 29, 2019, 6:22 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70754/
> -----------------------------------------------------------
>
> (Updated May 29, 2019, 6:22 p.m.)
>
>
> Review request for mesos, Benjamin Mahler and Meng Zhu.
>
>
> Bugs: MESOS-9793
> https://issues.apache.org/jira/browse/MESOS-9793
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Moved UPDATE_FRAMEWORK test helpers to appropriate namespaces.
>
>
> Diffs
> -----
>
> src/tests/master/update_framework_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/70754/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>