You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "macksonmu (via GitHub)" <gi...@apache.org> on 2023/04/21 08:51:36 UTC
[GitHub] [incubator-streampark] macksonmu opened a new pull request, #2676: Issue 2674
macksonmu opened a new pull request, #2676:
URL: https://github.com/apache/incubator-streampark/pull/2676
<!--
Thank you for contributing to StreamPark! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
## Contribution Checklist
- If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
- Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
-->
## What changes were proposed in this pull request
Issue Number: close #2674 <!-- REMOVE this line if no issue to close -->
<!--(For example: This pull request proposed to add checkstyle plugin).-->
## Brief change log
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verifying this change
<!--*(Please pick either of the following options)*-->
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
<!--*(example:)*
- *Added integration tests for end-to-end.*
- *Added *Test to verify the change.*
- *Manually verified the change by testing locally.* -->
## Does this pull request potentially affect one of the following parts
- Dependencies (does it add or upgrade a dependency): (yes / no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #2676: Issue 2674
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #2676:
URL: https://github.com/apache/incubator-streampark/pull/2676#discussion_r1173531572
##########
streampark-console/streampark-console-service/src/main/assembly/script/schema/mysql-schema.sql:
##########
@@ -357,7 +357,7 @@ create table `t_setting` (
drop table if exists `t_user`;
create table `t_user` (
`user_id` bigint not null auto_increment comment 'user id',
- `username` varchar(255) collate utf8mb4_general_ci not null comment 'user name',
+ `username` varchar(50) collate utf8mb4_general_ci not null comment 'user name',
`nick_name` varchar(50) collate utf8mb4_general_ci not null comment 'nick name',
`salt` varchar(255) collate utf8mb4_general_ci default null comment 'salt',
`password` varchar(128) collate utf8mb4_general_ci not null comment 'password',
Review Comment:
`password` varchar(64)
##########
streampark-console/streampark-console-service/src/main/assembly/script/schema/mysql-schema.sql:
##########
@@ -357,7 +357,7 @@ create table `t_setting` (
drop table if exists `t_user`;
create table `t_user` (
`user_id` bigint not null auto_increment comment 'user id',
- `username` varchar(255) collate utf8mb4_general_ci not null comment 'user name',
+ `username` varchar(50) collate utf8mb4_general_ci not null comment 'user name',
`nick_name` varchar(50) collate utf8mb4_general_ci not null comment 'nick name',
`salt` varchar(255) collate utf8mb4_general_ci default null comment 'salt',
Review Comment:
`salt` varchar(64)
##########
streampark-console/streampark-console-service/src/main/resources/db/schema-h2.sql:
##########
@@ -454,7 +454,7 @@ drop table if exists `t_yarn_queue`;
create table if not exists `t_yarn_queue` (
`id` bigint generated by default as identity not null comment 'queue id',
`team_id` bigint not null comment 'team id',
- `queue_label` varchar(255) not null comment 'queue label expression',
+ `queue_label` varchar(150) not null comment 'queue label expression',
Review Comment:
`queue_label` varchar(128)
##########
streampark-console/streampark-console-service/src/main/assembly/script/upgrade/pgsql/2.1.0.sql:
##########
@@ -40,7 +40,7 @@ create sequence "public"."streampark_t_yarn_queue_id_seq" increment 1 start 1000
create table "public"."t_yarn_queue" (
"id" int8 not null default nextval('streampark_t_yarn_queue_id_seq'::regclass),
"team_id" int8 not null,
- "queue_label" varchar(255) not null collate "pg_catalog"."default",
+ "queue_label" varchar(150) not null collate "pg_catalog"."default",
"description" varchar(512) collate "pg_catalog"."default",
Review Comment:
`description` varchar(256)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampark] wolfboys merged pull request #2676: [Bug] MySQL script error: Specified key was too long; max key length is 767 bytes
Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #2676:
URL: https://github.com/apache/incubator-streampark/pull/2676
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org