[GitHub] [helix] dasahcc commented on a change in pull request #626: Add default implementation to new interface methods

[GitBox <gi...@apache.org>]

dasahcc commented on a change in pull request #626: Add default implementation to new interface methods
URL: https://github.com/apache/helix/pull/626#discussion_r348843164
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/BaseDataAccessor.java
 ##########
 @@ -261,5 +263,7 @@
   /**
    * Close the connection to the metadata store
    */
-  void close();
+  default void close() {
+
 
 Review comment:
   Shall we print something such as "Default close method is invoked! No operation is executed." That can give user some hints.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org