You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by ardlema <gi...@git.apache.org> on 2015/05/05 13:05:20 UTC
[GitHub] metamodel pull request: Allow empty spaces before AS keyword. Fixe...
GitHub user ardlema opened a pull request:
https://github.com/apache/metamodel/pull/22
Allow empty spaces before AS keyword. Fixes #METAMODEL-138
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ardlema/metamodel MM-138-as-empty-spaces
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/22.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22
----
commit 61ea64ae007fc4e51967b15e3b6c241f4ff37a93
Author: Alberto Rodriguez <ar...@stratio.com>
Date: 2015-05-05T11:01:48Z
Allow empty spaces before AS keyword. Fixes #METAMODEL-138
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Allow empty spaces before AS keyword. Fixe...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/22#issuecomment-99111873
Ups my fault then. Sorry about that! Would you mind closing the PR and the Jira issue? Thank you in advance and sorry again
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Allow empty spaces before AS keyword. Fixe...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/22#issuecomment-99112070
Otherwise make an update to CHANGES.md and put the fixes-part into the commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Allow empty spaces before AS keyword. Fixe...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/22#issuecomment-99110267
You need to close the PR by referring to the PR's ID... So something like "Fixes #22"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Allow empty spaces before AS keyword. Fixe...
Posted by albertostratio <gi...@git.apache.org>.
Github user albertostratio commented on the pull request:
https://github.com/apache/metamodel/pull/22#issuecomment-99082558
I've just pushed to our "main" repo. Both the PR and the jira issue haven't been closed though (I've included the text "This closes #METAMODEL-138" in the last commit)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Allow empty spaces before AS keyword. Fixe...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/22#issuecomment-99053707
Looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Allow empty spaces before AS keyword. Fixe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Allow empty spaces before AS keyword. Fixe...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/22#issuecomment-99112018
I cannot close the PR actually, I thought you could :-P
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Allow empty spaces before AS keyword. Fixe...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/22#issuecomment-99053906
Feel free to push Alberto :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---