[GitHub] [incubator-paimon] zhangjun0x01 commented on a diff in pull request #1663: [flink] parse mysql-conf error when it contain `=`

["zhangjun0x01 (via GitHub)" <gi...@apache.org>]

zhangjun0x01 commented on code in PR #1663:
URL: https://github.com/apache/incubator-paimon/pull/1663#discussion_r1274534112


##########
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/action/ActionFactory.java:
##########
@@ -151,8 +151,8 @@ static Map<String, String> parseCommaSeparatedKeyValues(String keyValues) {
     }
 
     static void parseKeyValueString(Map<String, String> map, String kvString) {
-        String[] kv = kvString.split("=");
-        if (kv.length != 2) {
+        String[] kv = kvString.split("=", 2);
+        if (kv.length < 2) {

Review Comment:
   because we add the `limit` for `split` method, the max length of `kv` array is 2,  the exception is that the expression does not have `=`,  which means that `kv.length < 2`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org