[GitHub] [solr] HoustonPutman commented on pull request #876: SOLR-16210: skip Antora task for lift builds

[GitBox <gi...@apache.org>]

HoustonPutman commented on PR #876:
URL: https://github.com/apache/solr/pull/876#issuecomment-1136143176

   I agree that assemble is likely too heavy here. We already run `gradle check` which will do the site checking, and most checks on the `assemble` stuff. But I don't know what lift uses.
   
   
   
   > * Is "clean" actually necessary?  In general I think this is a habit we all bring from our Ant/Maven knowledge that Gradle should ideally make obsolete.
   
   If lift is looking at artifacts (tgzs) then clean might be necessary, because old artifact versions in the packaging release folder will not be deleted when `gradle assemble` is run. (This is only true when you are building a new solr version than what exists in the packaging releases folder, so we probably won't hit this often since this is just run on `main`)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org