You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by we...@apache.org on 2019/08/08 20:50:59 UTC

[hadoop] branch trunk updated: HDFS-14693. NameNode should log a warning when EditLog IPC logger's pending size exceeds limit. Contributed by Xudong Cao.

This is an automated email from the ASF dual-hosted git repository.

weichiu pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/hadoop.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 6ad9a11  HDFS-14693. NameNode should log a warning when EditLog IPC logger's pending size exceeds limit. Contributed by Xudong Cao.
6ad9a11 is described below

commit 6ad9a11494c3aea146d7741bf0ad52ce16ad08e6
Author: Wei-Chiu Chuang <we...@apache.org>
AuthorDate: Thu Aug 8 13:50:30 2019 -0700

    HDFS-14693. NameNode should log a warning when EditLog IPC logger's pending size exceeds limit. Contributed by Xudong Cao.
---
 .../java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
index 3247476..3a882e5 100644
--- a/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
+++ b/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/IPCLoggerChannel.java
@@ -492,6 +492,10 @@ public class IPCLoggerChannel implements AsyncLogger {
     Preconditions.checkArgument(size >= 0);
     if (queuedEditsSizeBytes + size > queueSizeLimitBytes &&
         queuedEditsSizeBytes > 0) {
+      QuorumJournalManager.LOG.warn("Pending edits to " + IPCLoggerChannel.this
+          + " is going to exceed limit size: " + queueSizeLimitBytes
+          + ", current queued edits size: " + queuedEditsSizeBytes
+          + ", will silently drop " + size + " bytes of edits!");
       throw new LoggerTooFarBehindException();
     }
     queuedEditsSizeBytes += size;


---------------------------------------------------------------------
To unsubscribe, e-mail: common-commits-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-commits-help@hadoop.apache.org