[jira] [Commented] (AIRFLOW-5357) Fix Content-Type for exported variables.json file

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-5357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919474#comment-16919474 ] 

ASF GitHub Bot commented on AIRFLOW-5357:
-----------------------------------------

kaxil commented on pull request #5962: [AIRFLOW-5357] Fix Content-Type for exported variables.json file
URL: https://github.com/apache/airflow/pull/5962
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-5357
   
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   Credits to Anurag Jain for reporting this:
   
   It was observed that the content type is set incorrectly while exporting variables in Apache Airflow. 
   
   Steps:
   >>> 
   >>> 1. Open the Apache Airflow
   >>> 2. Create a new variable at /admin/variable/
   >>> 3. Keep the key as <input> and value as <input>
   >>> 4. Save this variable
   >>> 5. Export this variable using Mozilla Firefox Browser
   >>> 6. Observe that the downloaded file is saved as <name>.json.htm instead of <name>.json. This happens since Apache airflow sets Response Content-Type as text/html instead of application/json which causes Browser to interpret it as a HTML
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [ ] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix Content-Type for exported variables.json file
> -------------------------------------------------
>
>                 Key: AIRFLOW-5357
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-5357
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: webserver
>    Affects Versions: 1.10.4
>            Reporter: Kaxil Naik
>            Assignee: Kaxil Naik
>            Priority: Major
>             Fix For: 1.10.5
>
>
> Credits to Anurag Jain for reporting this:
> It was observed that the content type is set incorrectly while exporting variables in Apache Airflow. 
> >>> 
> >>> Steps:
> >>> 
> >>> 1. Open the Apache Airflow
> >>> 2. Create a new variable at /admin/variable/
> >>> 3. Keep the key as <input> and value as <input>
> >>> 4. Save this variable
> >>> 5. Export this variable using Mozilla Firefox Browser
> >>> 6. Observe that the downloaded file is saved as <name>.json.htm instead of <name>.json. This happens since Apache airflow sets Response Content-Type as text/html instead of application/json which causes Browser to interpret it as a HTML 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)