[jira] [Commented] (DRILL-3167) When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client

["Deneche A. Hakim (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DRILL-3167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14562736#comment-14562736 ] 

Deneche A. Hakim commented on DRILL-3167:
-----------------------------------------

all unit tests are passing along with functional and tpch100

> When a query fails, Foreman should wait for all fragments to finish cleaning up before sending a FAILED state to the client
> ---------------------------------------------------------------------------------------------------------------------------
>
>                 Key: DRILL-3167
>                 URL: https://issues.apache.org/jira/browse/DRILL-3167
>             Project: Apache Drill
>          Issue Type: Bug
>            Reporter: Deneche A. Hakim
>            Assignee: Jacques Nadeau
>             Fix For: 1.1.0
>
>         Attachments: DRILL-3167.1.patch.txt
>
>
> TestDrillbitResilience.foreman_runTryEnd() exposes this problem intermittently
> The query fails and the Foreman reports the failure to the client which removes the results listener associated to the failed query. 
> Sometimes, a data batch reaches the client after the FAILED state already arrived, the client doesn't handle this properly and the corresponding buffer is never released.
> Making the Foreman wait for all fragments to finish before sending the final state should help avoid such scenarios.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)