You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2014/02/22 10:32:49 UTC
[Bug 124293] New: Section Range names truncated from underscore to
end in MSO .XLSX
https://issues.apache.org/ooo/show_bug.cgi?id=124293
Bug ID: 124293
Issue Type: DEFECT
Summary: Section Range names truncated from underscore to end
in MSO .XLSX
Product: Calc
Version: 4.1.0-dev
Hardware: All
OS: All
Status: CONFIRMED
Keywords: interop_OOXML
Severity: normal
Priority: P3
Component: open-import
Assignee: issues@openoffice.apache.org
Reporter: rainerbielefeld_ooo_qa@bielefeldundbuss.de
CC: issues@openoffice.apache.org
Created attachment 82664
--> https://issues.apache.org/ooo/attachment.cgi?id=82664&action=edit
Results
This one is a Spin Off from Bug 124256
Steps how to reproduce Reproducible with server installation of "AOO 4.1.0-Dev
– English UI / German locale - [AOO410m1(Build:9750) - Rev. 1566800 -
2014-02-12]" on German WIN7 Home Premium (64bit)", own separate user profile.
1. Open attachment 82614 “XLSX file containing a named range“
in AOO 4.1-dev and a copy of the document in AOO 3.4.1
2. In both do <control+f3>
3. Compare Range names in both Versions
Bug: Crippled Names in AOO 4.1, truncated from underscore to end
Additional Info
(a) I listed results found by
<https://issues.apache.org/ooo/show_bug.cgi?id=124256#c3>
In attached document
(b) We need to find out with what version the problem started
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
Andre <aw...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |awf.aoo@googlemail.com
--- Comment #4 from Andre <aw...@googlemail.com> ---
The name box is filled in ScPosWnd::FillRangeNames()
(sc/source/ui/app/inputwin.cxx). That names are still what is listed in the
XSLX file, without any underscore or anything else.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
--- Comment #2 from Rainer Bielefeld <ra...@bielefeldundbuss.de> ---
(c) Problem seems to be limited to XLSX import. Range Names are ok when I
open .ods created from reporter#s sample with AOO 3.4.1
with AOO 4.1-dev
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
Rainer Bielefeld <ra...@bielefeldundbuss.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |elish@apache.org,
| |j.nitschke@ok.de,
| |oliver.brinzing@gmx.de
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
--- Comment #6 from Rainer Bielefeld <ra...@bielefeldundbuss.de> ---
So it seems a "crutch" what has been used in older OOo versions no longer is
necessary? In old days identical names were not allowed for sections, still so
for manual entries, but now identical names are allowed for import and work?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
--- Comment #3 from j.nitschke@ok.de ---
it's not a defect, more a bad and confusing user experience imo
There is a feature in xls/xlsx which allows one range name to have different
meanings. Depending on what sheet you use the name, it can refer to different
ranges.
I tried to explain it in bug 124256, comment 7
AOO should show the name only once and select a different range depending which
sheet is shown.
or
AOO lists all names but shows the user somehow on what sheet what range is
valid, like in name define view but better. (if you don't know about the
feature the name define view is still confusing)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
--- Comment #11 from Andre <aw...@googlemail.com> ---
This issue was caused by commits for bug 120478.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
--- Comment #7 from Andre <aw...@googlemail.com> ---
@Rainer: I have not finished my analysis yet. Above comments are more a
reminder for me that allow me to continue after the weekend.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
--- Comment #12 from Andre <aw...@googlemail.com> ---
The navigator also shows the named ranges and seems to create their names with
its own algorithm (also without the underscore and sheet id).
What a mess.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
--- Comment #9 from Andre <aw...@googlemail.com> ---
Created attachment 82787
--> https://issues.apache.org/ooo/attachment.cgi?id=82787&action=edit
Concept of a fix.
This patch outlines the idea for a fix: insert entries into the ScPosWnd (that
is the implementing class of the Name Box control in the formula tool bar) that
encode both the range name and the sheed id, much like before the regression
was introduced. Don't change the range names in the ScRangeData structures.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
--- Comment #8 from Andre <aw...@googlemail.com> ---
Looks like the commits for bug 120478 are responsible for this bug: the sheet
id is now used internally to distinguish between the ranges. But the UI has
not been adapted. It only sees the range names, not the sheet ids. Therefore
the sheet id can not be used to look up the range.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
--- Comment #14 from Andre <aw...@googlemail.com> ---
Created attachment 82833
--> https://issues.apache.org/ooo/attachment.cgi?id=82833&action=edit
Additional changes.
A few changes missing from the last patch.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
Rainer Bielefeld <ra...@bielefeldundbuss.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rainerbielefeld_ooo_qa@biel
| |efeldundbuss.de
OS|All |Windows 7
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
Andre <aw...@googlemail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82787|0 |1
is obsolete| |
--- Comment #13 from Andre <aw...@googlemail.com> ---
Created attachment 82812
--> https://issues.apache.org/ooo/attachment.cgi?id=82812&action=edit
Better fix.
A better fix that displays ranges as "<name> (<sheet>)" both in the name box
and the navigator. Internally a different naming scheme "<name>_<sheet>" is
used because that has worked before and should not interfere with other range
or database names too much.
It even works to change the range via the navigator and then have the name box
updated (the reverse does not work due to missing functionality in the
navigator).
@Rainer: Comment 2 mentions that the named ranges work when imported from .ods
files written by AOO 3.4.1. Can you attach such a file?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
Rainer Bielefeld <ra...@bielefeldundbuss.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82664|application/vnd.sun.xml.cal |application/vnd.oasis.opend
mime type|c |ocument.spreadsheet
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
--- Comment #5 from Andre <aw...@googlemail.com> ---
The named ranges are imported in DefinedNames::importDefinedName(const
AttbibuteList&) (in oox/source/xls/defnamesbuffer.cxx).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
Rainer Bielefeld <ra...@bielefeldundbuss.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest|--- |4.1-dev
Confirmation on| |
Version|4.1.0-dev |4.0.0
--- Comment #1 from Rainer Bielefeld <ra...@bielefeldundbuss.de> ---
Already Reproducible with server installation of " AOO 4.0.0-Dev – English UI /
German locale [AOO400m1(Build:9700) - Rev. 1457992 – Rev.1457606
((2013-03-19))]" on German WIN7 Home Premium (64bit)", own separate user
profile
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
--- Comment #10 from Andre <aw...@googlemail.com> ---
@all: What would be the preferred name? Before the regression was introduced I
think it was <range-name>_<sheet-id>. At the moment it is just <range-name>.
We need a name that contains both (range-name and sheet-id).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 124293] Section Range names truncated from underscore to end in
MSO .XLSX
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=124293
Rainer Bielefeld <ra...@bielefeldundbuss.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |regression
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.