You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by shwetaag <gi...@git.apache.org> on 2015/08/21 14:36:24 UTC
[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...
GitHub user shwetaag opened a pull request:
https://github.com/apache/cloudstack/pull/729
CLOUDSTACK-8757:FTP modules are not loaded in VR
check bug 8757 for more details .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shwetaag/cloudstack router
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/729.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #729
----
commit cc308050b8e50516c50b02d99934d5ea14304ac4
Author: shweta agarwal <sh...@citrix.com>
Date: 2015-08-21T12:34:19Z
CLOUDSTACK-8757:FTP modules are not loaded in VR
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...
Posted by shwetaag <gi...@git.apache.org>.
Github user shwetaag commented on the pull request:
https://github.com/apache/cloudstack/pull/729#issuecomment-134502839
Result information:
test_01_FTPModulesInVR (integration.component.maint.test_escalations_routers.TestVR) ... === TestName: test_01_FTPModulesInVR | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 233.348s
OK
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/729#issuecomment-134706080
@shwetaag Thanks. I was also able to run your test. Please change the title, see previous comment.
```
[root@cs2 cloudstack]# cat /tmp//MarvinLogs/test_escalations_routers_G3E8EO/results.txt
@desc: Verify FTP modules are loaded in VR of advance zone ... === TestName: test_01_FTPModulesInVR | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 1 test in 415.669s
OK
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/729#issuecomment-134364759
@shwetaag Could you change the title to: "CLOUDSTACK-8757: Test to verify if FTP modules are loaded in VR" as right now it looks like there is a defect, which there is not.
Also, could you post the test results please. I'll have a look tomorrow and see if I can run the test as well.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/729#issuecomment-134912770
Code LGTM (not tested on a real infra though), merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...
Posted by shwetaag <gi...@git.apache.org>.
Github user shwetaag commented on the pull request:
https://github.com/apache/cloudstack/pull/729#issuecomment-134030869
@remibergsma : i have added details to the bug . Copy pasting for your reference
To have Active FTP working in isolated networks VRs need the have the following modules loaded (In order to map the FTP Data and FTP CMD to the same frontend IP):
modprobe nf_conntrack_ftp
modprobe nf_nat_ftp
in some versions of Cloudstack we noted that these modules are not loaded on CS Routers by default . So this test case is for verifying that these modules are loaded by default in VR and if not report an error
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/729#issuecomment-133547422
@shwetaag Can you please add more details? The Jira issue only has a title. Are you submitting a test so in case the modules are not loaded, alarms go off? Or do you think it is actually broken right now in master?
When I test it, it seems to work:
```
root@r-3-VM:~# lsmod | grep ftp
nf_nat_ftp 12460 0
nf_nat 18242 2 nf_nat_ftp,iptable_nat
nf_conntrack_ftp 12605 1 nf_nat_ftp
nf_conntrack 52720 7 nf_conntrack_ipv4,nf_conntrack_ftp,nf_nat,nf_nat_ftp,iptable_nat,xt_state,xt_connmark
```
If you want to submit a test (which is great btw!), then please update the title of the PR and the Jira issue accordingly. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: CLOUDSTACK-8757:FTP modules are not loade...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/729
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---