You are viewing a plain text version of this content. The canonical link for it is here.

Posted to user@flink.apache.org by Kenzyme <kl...@kenzymele.com> on 2020/10/13 02:48:15 UTC

Missing annotation in SimpleJdbcConnectionProvider.java ?

Hi,

I would like to know if class [SimpleJdbcConnectionProvider](https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/connection/SimpleJdbcConnectionProvider.java).java should be marked as @Internal or @PublicEvolving? Since there's annotation provided, I'm unsure if I should be using this class in my user code.

If one of them is missing, I would like to create a PR for this if that's fine as well.

Thank you for the clarification!

Kenzyme Le

Re: Missing annotation in SimpleJdbcConnectionProvider.java ?

Posted by Kenzyme <kl...@kenzymele.com>.

After careful examination, seems like it should be marked as @Internal since this class is located in package org.apache.flink.connector.jdbc.internal.connection.

Here is my PR related to this https://github.com/apache/flink/pull/13603 .

Thanks a lot!

Kenzyme Le

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Monday, October 12th, 2020 at 10:48 PM, Kenzyme <kl...@kenzymele.com> wrote:

> Hi,
>
> I would like to know if class [SimpleJdbcConnectionProvider](https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-jdbc/src/main/java/org/apache/flink/connector/jdbc/internal/connection/SimpleJdbcConnectionProvider.java).java should be marked as @Internal or @PublicEvolving? Since there's annotation provided, I'm unsure if I should be using this class in my user code.
>
> If one of them is missing, I would like to create a PR for this if that's fine as well.
>
> Thank you for the clarification!
>
> Kenzyme Le