You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by kunal642 <gi...@git.apache.org> on 2017/11/17 07:33:57 UTC
[GitHub] carbondata pull request #1521: [WIP] [CARBONDATA-1743] fix conurrent pre-agg...
GitHub user kunal642 opened a pull request:
https://github.com/apache/carbondata/pull/1521
[WIP] [CARBONDATA-1743] fix conurrent pre-agg creation and query
Be sure to do all of the following checklist to help us incorporate
your contribution quickly and easily:
- [ ] Any interfaces changed?
- [ ] Any backward compatibility impacted?
- [ ] Document update required?
- [ ] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kunal642/carbondata concurrent_query
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/1521.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1521
----
commit 8952423e18a0c36afe08c5ead3730ff48fc3661e
Author: kunal642 <ku...@gmail.com>
Date: 2017-11-17T06:43:25Z
fix conurrent pre-agg creation and query
----
---
[GitHub] carbondata issue #1521: [WIP] [CARBONDATA-1743] fix conurrent pre-agg creati...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1521
@kunal642 Please update PR description
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/858/
---
[GitHub] carbondata issue #1521: [WIP] [CARBONDATA-1743] fix conurrent pre-agg creati...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1343/
---
[GitHub] carbondata pull request #1521: [WIP] [CARBONDATA-1743] fix conurrent pre-agg...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1521#discussion_r154637843
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala ---
@@ -197,8 +197,17 @@ case class CarbonPreAggregateQueryRules(sparkSession: SparkSession) extends Rule
.asInstanceOf[LogicalRelation]
(selectedDataMapSchema, carbonRelation)
}.minBy(f => f._2.relation.asInstanceOf[CarbonDatasourceHadoopRelation].sizeInBytes)
- // transform the query plan based on selected child schema
- transformPreAggQueryPlan(plan, aggDataMapSchema, carbonRelation)
+ if (carbonRelation.relation.asInstanceOf[CarbonDatasourceHadoopRelation].sizeInBytes ==
--- End diff --
While calculating `sizeInBytes` in CarbonRelation we can first check the size of the valid segments and then calculate the store size of that table.
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on the issue:
https://github.com/apache/carbondata/pull/1521
LGTM
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1521
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2322/
---
[GitHub] carbondata pull request #1521: [CARBONDATA-1743] fix conurrent pre-agg creat...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/1521
---
[GitHub] carbondata issue #1521: [WIP] [CARBONDATA-1743] fix conurrent pre-agg creati...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1521
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1796/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1521
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2381/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2000/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1521
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2316/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/813/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/783/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2012/
---
[GitHub] carbondata issue #1521: [WIP] [CARBONDATA-1743] fix conurrent pre-agg creati...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1228/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/777/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by kunal642 <gi...@git.apache.org>.
Github user kunal642 commented on the issue:
https://github.com/apache/carbondata/pull/1521
@ravipesala Please review
---
[GitHub] carbondata issue #1521: [WIP] [CARBONDATA-1743] fix conurrent pre-agg creati...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1521
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/1849/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1521
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2355/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Failed with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/769/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/905/
---
[GitHub] carbondata issue #1521: [WIP] [CARBONDATA-1743] fix conurrent pre-agg creati...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1404/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1521
SDV Build Fail , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2413/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Success with Spark 2.2.0, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/822/
---
[GitHub] carbondata issue #1521: [WIP] [CARBONDATA-1743] fix conurrent pre-agg creati...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1521
@kunal642 Please rebase and fix the build
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2083/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2044/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/2131/
---
[GitHub] carbondata pull request #1521: [CARBONDATA-1743] fix conurrent pre-agg creat...
Posted by kumarvishal09 <gi...@git.apache.org>.
Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/1521#discussion_r157697249
--- Diff: integration/spark2/src/main/scala/org/apache/spark/sql/hive/CarbonPreAggregateRules.scala ---
@@ -308,9 +308,18 @@ case class CarbonPreAggregateQueryRules(sparkSession: SparkSession) extends Rule
val relation = sparkSession.sessionState.catalog.lookupRelation(identifier)
(selectedDataMapSchema, carbonRelation, relation)
}.minBy(f => f._2.sizeInBytes)
- val newRelation = new FindDataSourceTable(sparkSession).apply(relation)
- // transform the query plan based on selected child schema
- transformPreAggQueryPlan(plan, aggDataMapSchema, newRelation)
+ if (carbonRelation.sizeInBytes ==
--- End diff --
This is not the correct place to handle this issue....in this case if many aggregate table is matching the query expression in and smallest is of zero size then it will hit the maintable but we need to check the size of other aggregate table also
---
[GitHub] carbondata issue #1521: [WIP] [CARBONDATA-1743] fix conurrent pre-agg creati...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/1521
Build Failed with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/1220/
---
[GitHub] carbondata issue #1521: [CARBONDATA-1743] fix conurrent pre-agg creation and...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/1521
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/2324/
---