You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2018/04/10 17:42:00 UTC
[jira] [Commented] (GEODE-4991) JDBC connector should not hard code
quotes around identifiers in SQL statements
[ https://issues.apache.org/jira/browse/GEODE-4991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432646#comment-16432646 ]
ASF subversion and git services commented on GEODE-4991:
--------------------------------------------------------
Commit 3efb4da0fb79ad418e0b463e31dd31b23788696b in geode's branch refs/heads/develop from [~dschneider]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=3efb4da ]
GEODE-4991: do no use hard coded quotes (#1728)
java.sql.DatabaseMetaData.getIdentifierQuoteString is now used when quoting identifiers.
If this method returns null, an empty string, or a string with all spaces then no quoting will be done.
> JDBC connector should not hard code quotes around identifiers in SQL statements
> -------------------------------------------------------------------------------
>
> Key: GEODE-4991
> URL: https://issues.apache.org/jira/browse/GEODE-4991
> Project: Geode
> Issue Type: Bug
> Components: extensions, regions
> Affects Versions: 1.6.0
> Reporter: Darrel Schneider
> Assignee: Darrel Schneider
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Currently the JDBC connector has double quotes around all identifiers in SQL statements it creates.
> Instead of always using double quotes, it should instead ask JDBC using java.sql.DatabaseMetaData.getIdentifierQuoteString() what the quote string is and use that.
> For databases that do not support quoting identifiers a space is returned.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)