[GitHub] [superset] Rohit-pawar902 commented on a diff in pull request #23155: fix :Extra column in csv while sending csv on email

["Rohit-pawar902 (via GitHub)" <gi...@apache.org>]

Rohit-pawar902 commented on code in PR #23155:
URL: https://github.com/apache/superset/pull/23155#discussion_r1119592497


##########
superset/config.py:
##########
@@ -748,6 +748,10 @@ def _try_json_readsha(filepath: str, length: int) -> Optional[str]:
 # note: index option should not be overridden
 CSV_EXPORT = {"encoding": "utf-8"}
 
+#It Is used for enable/disable the index sequence for csv which came at email-time,
+#rearly someone want the index in csv so by-default it is false
+CSV_INDEX={"index":False}
+

Review Comment:
   @betodealmeida Your all changes looks good and thanks for responce. 
   But According to this comment :
   https://github.com/apache/superset/issues/22981#issuecomment-1440410419
   I would thing we don't have to give config `opt true/false` , instead we can make this  `processed_df.to_csv(buf, index=config["CSV_INDEX"]) ` to processed_df.to_csv(buf, index=False) Because it is really a bug.
   what do you think ? I like to listen your thougts regarding to this.
   @Antonio-RiveroMartnez 
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org