You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Phil Steitz <ph...@gmail.com> on 2014/04/12 19:31:52 UTC
[DBCP] changes in r
The changes to TestConnectionPool to make findbugs happy in r
1572068 [1] eliminated the explicit close of resources, which I
think is not a good practice to promote in the unit tests and it
also makes the test harder to follow / modify. Sorry I missed this
when the commit was made. Any objections to adding back the explicit
close of the resultset, statement and connection objects created in
the TestThread run method?
Phil
[1] http://s.apache.org/gIT
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: [DBCP] changes in r
Posted by Phil Steitz <ph...@gmail.com>.
Thinking about this some more, I take that back. I don't need to do
anything here and the idiom is OK. Sorry for the noise.
Phil
On 4/12/14, 10:31 AM, Phil Steitz wrote:
> The changes to TestConnectionPool to make findbugs happy in r
> 1572068 [1] eliminated the explicit close of resources, which I
> think is not a good practice to promote in the unit tests and it
> also makes the test harder to follow / modify. Sorry I missed this
> when the commit was made. Any objections to adding back the explicit
> close of the resultset, statement and connection objects created in
> the TestThread run method?
>
> Phil
>
> [1] http://s.apache.org/gIT
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org