You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/08/25 07:27:58 UTC
[kudu-CR] KUDU-687: add replication factor to KuduTable
Adar Dembo has uploaded a new change for review.
http://gerrit.cloudera.org:8080/4123
Change subject: KUDU-687: add replication factor to KuduTable
......................................................................
KUDU-687: add replication factor to KuduTable
This is generally useful, and necessary if ksck is to use the C++ client.
While I was at it, I reduced the use of a second table in client-test to
only those tests that actually needed it.
Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
7 files changed, 65 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/4123/1
--
To view, visit http://gerrit.cloudera.org:8080/4123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
[kudu-CR] KUDU-687: add replication factor to KuduTable
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-687: add replication factor to KuduTable
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] KUDU-687: add replication factor to KuduTable
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: KUDU-687: add replication factor to KuduTable
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3067/
--
To view, visit http://gerrit.cloudera.org:8080/4123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-687: add replication factor to KuduTable
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: KUDU-687: add replication factor to KuduTable
......................................................................
KUDU-687: add replication factor to KuduTable
This is generally useful, and necessary if ksck is to use the C++ client.
While I was at it, I reduced the use of a second table in client-test to
only those tests that actually needed it.
Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Reviewed-on: http://gerrit.cloudera.org:8080/4123
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/client/client-internal.cc
M src/kudu/client/client-internal.h
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
M src/kudu/client/client.h
M src/kudu/client/table-internal.cc
M src/kudu/client/table-internal.h
7 files changed, 65 insertions(+), 26 deletions(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] KUDU-687: add replication factor to KuduTable
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: KUDU-687: add replication factor to KuduTable
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4123/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
Line 3262: for (int i : { 1, 3, 5, 7, 9 }) {
hrm, how does this work if there are not 9 tablet servers in the minicluster?
--
To view, visit http://gerrit.cloudera.org:8080/4123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] KUDU-687: add replication factor to KuduTable
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: KUDU-687: add replication factor to KuduTable
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/4123/1/src/kudu/client/client-test.cc
File src/kudu/client/client-test.cc:
Line 3262: for (int i : { 1, 3, 5, 7, 9 }) {
> hrm, how does this work if there are not 9 tablet servers in the minicluste
ClientTest::CreateTable() is magical; it adds enough tservers to satisfy the table's replication factor.
--
To view, visit http://gerrit.cloudera.org:8080/4123
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If76ec6c3001e78a31517991d7432f79d4645fccc
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: Yes