You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by ahgittin <gi...@git.apache.org> on 2017/12/06 16:26:32 UTC
[GitHub] brooklyn-server pull request #911: Different fix for entity spec mutated bug...
GitHub user ahgittin opened a pull request:
https://github.com/apache/brooklyn-server/pull/911
Different fix for entity spec mutated bug BROOKLYN-657
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ahgittin/brooklyn-server entity-spec-mutated
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-server/pull/911.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #911
----
----
---
[GitHub] brooklyn-server issue #911: Different fix for entity spec mutated bug BROOKL...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the issue:
https://github.com/apache/brooklyn-server/pull/911
LGTM, and confirmed that the example test in https://issues.apache.org/jira/browse/BROOKLYN-567 now works (with the persisted state files not increasing in size).
---
[GitHub] brooklyn-server pull request #911: Different fix for entity spec mutated bug...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-server/pull/911
---
[GitHub] brooklyn-server issue #911: Different fix for entity spec mutated bug BROOKL...
Posted by ahgittin <gi...@git.apache.org>.
Github user ahgittin commented on the issue:
https://github.com/apache/brooklyn-server/pull/911
@bostko thanks for #907 - i think this is a further simplification but can you confirm?
(BTW merging this will also merge #907)
---
[GitHub] brooklyn-server pull request #911: Different fix for entity spec mutated bug...
Posted by bostko <gi...@git.apache.org>.
Github user bostko commented on a diff in the pull request:
https://github.com/apache/brooklyn-server/pull/911#discussion_r155337371
--- Diff: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java ---
@@ -509,13 +509,11 @@ public EntitySpecSupplier(EntitySpecConfiguration flag) {
this.flag = flag;
}
@Override public EntitySpec<?> get() {
- EntitySpecConfiguration specConfig = (EntitySpecConfiguration) flag;
// TODO: This should called from BrooklynAssemblyTemplateInstantiator.configureEntityConfig
// And have transformSpecialFlags(Object flag, ManagementContext mgmt) drill into the Object flag if it's a map or iterable?
@SuppressWarnings("unchecked")
- Map<String, Object> resolvedConfig = (Map<String, Object>)transformSpecialFlags(specConfig.getSpecConfiguration());
- specConfig.setSpecConfiguration(resolvedConfig);
--- End diff --
Good fix as well. Now I think `setSpecConfiguration` method should be also removed.
BROOKLYN-567
---