You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@teaclave.apache.org by Qinkun Bao <no...@github.com.INVALID> on 2021/11/04 22:21:23 UTC

[apache/incubator-teaclave] [WAMR] check init return values (PR #573)

## Description

Function `wasm_runtime_init ` may fail. This PR validates the return value.
You can view, comment on, or merge this pull request online at:

  https://github.com/apache/incubator-teaclave/pull/573

-- Commit Summary --

  * <a href="https://github.com/apache/incubator-teaclave/pull/573/commits/e74ee8814b4cc5f8aa68923bc16a4ce05c869b4b">[WAMR] check init return values</a>

-- File Changes --

    M executor/src/wamr.rs (4)

-- Patch Links --

https://github.com/apache/incubator-teaclave/pull/573.patch
https://github.com/apache/incubator-teaclave/pull/573.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/573

Re: [apache/incubator-teaclave] [WAMR] check init return values (PR #573)

Posted by Mingshen Sun <no...@github.com.INVALID>.

Merged #573 into master.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/573#event-5628631095

Re: [apache/incubator-teaclave] [WAMR] check init return values (PR #573)

Posted by Mingshen Sun <no...@github.com.INVALID>.

Merged. Thanks!

However, we still need a better solution to handle any errors from WAMR so that any issues with the executor will not break our service.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/apache/incubator-teaclave/pull/573#issuecomment-970970838