[jira] Commented: (FELIX-26) Improve native library matching algorithm

["Richard S. Hall (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/jira/browse/FELIX-26?page=comments#action_12432212 ] 
            
Richard S. Hall commented on FELIX-26:
--------------------------------------

Ok, I have committed my tinkering with this issue...now I will pass it back to Arnaud if he wants to play with it some more and/or review my changes to his original patch.

As far as I can tell, this appears to have improved our score on the TCK, now we are only failing two cases: 1) when the osname alias is used and 2) the fragment case, which is expected. I didn't look into issue (1), but I believe we should be able to fix this...issue (2) will have to wait. I will update the wiki TCK status page with this information.

There are at least a few other issues that need to be addressed (besides fragments) that I know of:

1) The code assumes the "*" optional clause will come last, but I do not believe that it enforces this, which should be the case.

2) The code assumes that there is only a single selection filter parameter, but I believe that there can be any number of selection filters, just like any other parameter like osname.

3) The spec says that we need fail at installation time if a selected native library cannot be found in the bundle, but currently we do not check for this.

There may be more issues lurking in there, so we need to go over it in more detail, but it is a good start. Thanks Arnaud.

> Improve native library matching algorithm
> -----------------------------------------
>
>                 Key: FELIX-26
>                 URL: http://issues.apache.org/jira/browse/FELIX-26
>             Project: Felix
>          Issue Type: Improvement
>          Components: Specification compliance, Framework
>            Reporter: Richard S. Hall
>         Assigned To: Richard S. Hall
>         Attachments: 2006-08-29_FELIX-26_patch.zip, 2006-08-29_FELIX-26_patch2.zip, 2006-08-30_FELIX-26_patch3.zip
>
>
> This issue is described in section 3.9 of the OSGi R4 specification. R4 has improved and made the native library matching alogirithm; this is invoked when a bundle's class loader is asked for the native library when a class in the bundle has a native method. The current Felix implementation is a simplified version of the OSGi R3 algorithm. This change should be localized to the org.apache.felix.framework.OSGiLibrarySource class.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira