You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@nutch.apache.org by thammegowda <gi...@git.apache.org> on 2016/04/25 14:53:49 UTC

[GitHub] nutch pull request: Option to include inlinks in commonscrawl dump

GitHub user thammegowda opened a pull request:

    https://github.com/apache/nutch/pull/106

    Option to include inlinks in commonscrawl dump

    This PR enhances the CommonCrawlDumper with an optional CLI argument to accept linkdb path.
    When this option is supplied, an additional field called "inlinks" will be included in the dump files.
    
    
    We enhanced this as part of MEMEX crawler for analysing crawl link graph from dump files we believe this may be useful for other nutch users as well.
    
    
    CC @sujen1412 @chrismattmann 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/thammegowda/nutch ccdump-inlinks

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nutch/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #106
    
----
commit 6ff1ecbbb8527f760a81a316ffa6ae5b823f980a
Author: Thamme Gowda <tg...@gmail.com>
Date:   2016-04-19T00:57:11Z

    option to inlcude inlinks in commons crawl dump

commit a08804913c500b331c9296996ce1ba3d4929d3a8
Author: Thamme Gowda <tg...@gmail.com>
Date:   2016-04-19T02:20:38Z

    Handling duplicate inlinks

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nutch pull request: Option to include inlinks in commonscrawl dump

Posted by lewismc <gi...@git.apache.org>.

Github user lewismc commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/106#discussion_r61160255
  
    --- Diff: src/java/org/apache/nutch/tools/AbstractCommonCrawlFormat.java ---
    @@ -23,6 +23,7 @@
     import java.net.URLEncoder;
     import java.net.UnknownHostException;
    --- End diff --
    
    Hi @thammegowda can you pleaae reformat this entire file to have 2 space indents here? I can review this PR once that is done. Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nutch pull request: Option to include inlinks in commonscrawl dump

Posted by thammegowda <gi...@git.apache.org>.

Github user thammegowda commented on a diff in the pull request:

    https://github.com/apache/nutch/pull/106#discussion_r61677363
  
    --- Diff: src/java/org/apache/nutch/tools/AbstractCommonCrawlFormat.java ---
    @@ -23,6 +23,7 @@
     import java.net.URLEncoder;
     import java.net.UnknownHostException;
    --- End diff --
    
    @lewismc 
    As you had noticed it was previously formatted with tabs. I reformatted to 2 spaces.
    I used IntelliJ Idea to reformat, I hope that followed all the style rules in `eclipse-codeformat.xml`. 
    Please review and also let me know if you find any issues. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] nutch pull request: Option to include inlinks in commonscrawl dump

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/nutch/pull/106


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---