You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2021/04/14 13:14:57 UTC
[GitHub] [gobblin] vikrambohra opened a new pull request #3259: [GOBBLIN-1423] Add config to Event reporter to control queue capacity…
vikrambohra opened a new pull request #3259:
URL: https://github.com/apache/gobblin/pull/3259
… and offer timeout
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
- Added reference to Config in EventReporter
- pass config to reporters via user configs
- Control queue capacity and queue offer timeout via configs
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
Added testEventReporterConfigs
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] vikrambohra closed pull request #3259: [GOBBLIN-1423] Add config to Event reporter to control queue capacity…
Posted by GitBox <gi...@apache.org>.
vikrambohra closed pull request #3259:
URL: https://github.com/apache/gobblin/pull/3259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] vikrambohra commented on a change in pull request #3259: [GOBBLIN-1423] Add config to Event reporter to control queue capacity…
Posted by GitBox <gi...@apache.org>.
vikrambohra commented on a change in pull request #3259:
URL: https://github.com/apache/gobblin/pull/3259#discussion_r614242250
##########
File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/reporter/EventReporter.java
##########
@@ -189,13 +212,20 @@ public void run() {
protected MetricFilter filter;
protected TimeUnit rateUnit;
protected TimeUnit durationUnit;
+ protected Config config;
protected Builder(MetricContext context) {
this.context = context;
this.name = "MetricReportReporter";
this.rateUnit = TimeUnit.SECONDS;
this.durationUnit = TimeUnit.MILLISECONDS;
this.filter = MetricFilter.ALL;
+ this.config = ConfigFactory.empty();
+ }
+
+ public T withConfig(Config config) {
Review comment:
That's an option, however we call builder.withConfig at 4 places in KafkaReportingFormats.java that means we will have to parse and set queue capacity and timeout at 4 places (and more for future requests).
The config keys and fallback logic to queue capacity and timeout should be contained in EventReporter IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] asfgit closed pull request #3259: [GOBBLIN-1423] Add config to Event reporter to control queue capacity…
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3259:
URL: https://github.com/apache/gobblin/pull/3259
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] sv2000 commented on a change in pull request #3259: [GOBBLIN-1423] Add config to Event reporter to control queue capacity…
Posted by GitBox <gi...@apache.org>.
sv2000 commented on a change in pull request #3259:
URL: https://github.com/apache/gobblin/pull/3259#discussion_r614224509
##########
File path: gobblin-metrics-libs/gobblin-metrics-base/src/main/java/org/apache/gobblin/metrics/reporter/EventReporter.java
##########
@@ -189,13 +212,20 @@ public void run() {
protected MetricFilter filter;
protected TimeUnit rateUnit;
protected TimeUnit durationUnit;
+ protected Config config;
protected Builder(MetricContext context) {
this.context = context;
this.name = "MetricReportReporter";
this.rateUnit = TimeUnit.SECONDS;
this.durationUnit = TimeUnit.MILLISECONDS;
this.filter = MetricFilter.ALL;
+ this.config = ConfigFactory.empty();
+ }
+
+ public T withConfig(Config config) {
Review comment:
Should we be more explicit and have methods withQueueCapacity(int) and withReportingInterval(int)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] sv2000 commented on a change in pull request #3259: [GOBBLIN-1423] Add config to Event reporter to control queue capacity…
Posted by GitBox <gi...@apache.org>.
sv2000 commented on a change in pull request #3259:
URL: https://github.com/apache/gobblin/pull/3259#discussion_r614473514
##########
File path: gobblin-modules/gobblin-kafka-common/src/test/java/org/apache/gobblin/metrics/reporter/KafkaEventReporterTest.java
##########
@@ -54,7 +57,7 @@ public void testKafkaEventReporter() throws IOException {
MockKafkaPusher pusher = new MockKafkaPusher();
KafkaEventReporter kafkaReporter = getBuilder(context, pusher).build("localhost:0000", "topic");
-
+ kafkaReporter.getQueueCapacity();
Review comment:
Seems like we are ignoring the return value here. If not needed, remove this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org