You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "NissimShiman (via GitHub)" <gi...@apache.org> on 2023/03/31 18:35:18 UTC
[GitHub] [nifi] NissimShiman opened a new pull request, #7107: NIFI-10756 Generate error message when processor and/or controller service is unable to transition to start and/or enabled state
NissimShiman opened a new pull request, #7107:
URL: https://github.com/apache/nifi/pull/7107
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-10756](https://issues.apache.org/jira/browse/NIFI-10756)
Processors in start state and controller services in enabled state will fail silently on nifi startup if a resource they rely on is missing.
This adds logging/bulletins to alert users to this situation after two minutes as well as after each hour nifi is still trying to start these components.
**To test processor:**
Set up GenerateFlowFile -> IdentifyMimeType flow
where IdentifyMimeTypes's Config File property is set to
[config file](https://github.com/apache/nifi/blob/rel/nifi-1.20.0/nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/resources/TestIdentifyMimeType/.customConfig.xml)
Start IdentifyMimeType
stop nifi
move/rename config file
start nifi
IdentifyMimeType will not start.
Before this fix there is no error.
There will now be an error (and bulletin) after two minutes as well as each hour.
Restoring the config file to its original location will allow the processor to reach Start state and stop these errors.
**To test controller service:**
Enable StandardSSLContextService controller service
stop nifi
move/rename keystore (and/or truststore) that controller service is pointing to
start nifi
StandardSSLContextService will not start.
Before this fix there is no error.
There will now be an error (and bulletin) after two minutes as well as each hour.
Restoring the keystore/truststore file to its original location will allow the controller service to reach Enabled state and will stop these errors.
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mosermw commented on pull request #7107: NIFI-10756 Generate error message when processor and/or controller service is unable to transition to start and/or enabled state
Posted by "mosermw (via GitHub)" <gi...@apache.org>.
mosermw commented on PR #7107:
URL: https://github.com/apache/nifi/pull/7107#issuecomment-1545870787
Whoops I forgot to include "This closes #7107" in the commit message, and I don't appear to have write access to mark this PR as merged. If someone with permission can close this PR, I would appreciate it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mosermw commented on pull request #7107: NIFI-10756 Generate error message when processor and/or controller service is unable to transition to start and/or enabled state
Posted by "mosermw (via GitHub)" <gi...@apache.org>.
mosermw commented on PR #7107:
URL: https://github.com/apache/nifi/pull/7107#issuecomment-1542814528
I can review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #7107: NIFI-10756 Generate error message when processor and/or controller service is unable to transition to start and/or enabled state
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory closed pull request #7107: NIFI-10756 Generate error message when processor and/or controller service is unable to transition to start and/or enabled state
URL: https://github.com/apache/nifi/pull/7107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mosermw commented on pull request #7107: NIFI-10756 Generate error message when processor and/or controller service is unable to transition to start and/or enabled state
Posted by "mosermw (via GitHub)" <gi...@apache.org>.
mosermw commented on PR #7107:
URL: https://github.com/apache/nifi/pull/7107#issuecomment-1544577294
Tested this with 2.0.0-SNAPSHOT and 1.22.0-SNAPSHOT, using a LookupAttribute processor and XmlFileLookupService and the ERROR messages and bulletins appear as expected.
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] NissimShiman commented on pull request #7107: NIFI-10756 Generate error message when processor and/or controller service is unable to transition to start and/or enabled state
Posted by "NissimShiman (via GitHub)" <gi...@apache.org>.
NissimShiman commented on PR #7107:
URL: https://github.com/apache/nifi/pull/7107#issuecomment-1545629884
Thank you for reviewing this @mosermw!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on pull request #7107: NIFI-10756 Generate error message when processor and/or controller service is unable to transition to start and/or enabled state
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on PR #7107:
URL: https://github.com/apache/nifi/pull/7107#issuecomment-1546047874
Thanks @mosermw. I can close the PR, you should be able to link your Apache account to your GitHub account following the steps, which would allow you to close pull request in the GitHub project.
https://infra.apache.org/apache-github.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org