[GitHub] [spark] weixiuli edited a comment on pull request #31941: [SPARK-34637][SQL] Improve the performance of AQE and DPP through logical optimization.

[GitBox <gi...@apache.org>]

weixiuli edited a comment on pull request #31941:
URL: https://github.com/apache/spark/pull/31941#issuecomment-806290680


   > When found the `buildPlan `in `SubqueryAdaptiveBroadcastExec `can be reused, we can apply the DPP filter firstly(same with the `PlanDynamicPruningFilters `rule) and then back the AQE framework to reuse the broadcast exchange in the build side. And If the build side exchange is running and not finished, we can use the wait or cancel this stage mechanism to avoid the broadcast exchange be executed twice.
   > 
   > @cloud-fan @weixiuli Please correct me if wrong understandings. Thanks.
   
   Yes, when the InputPlan has a build-side BroadcastHashJoinExec before the adaptive dynamic trimming optimizer rule,
   we should ensure that the build plan can be created by the DPP when not created by the AQE, and that the AQE can reuse it later, or that the DPP can reuse it when it has already been created by the AQE. Not only does it avoid  the broadcast exchange be executed twice,  but it also guarantees that BuildPlan can be created and used by the DPP if it is not created by the AQE, which is beneficial to both the DPP and AQE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org