Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

[Sure <su...@qq.com>]

+1


All tests are passed

------------------ Original ------------------
From: preethi <ka...@gmail.com>
Date: Tue,Feb 20,2018 2:14 PM
To: dev <de...@servicecomb.apache.org>
Subject: Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1



+1 Verified build from source on both Linux and windows

On 2018/02/19 10:07:00, Mohammad Asif Siddiqui wrote:
 > Hi All,>
 > This is a call for vote to release ServiceComb Service-Center 
(Incubating)  version 1.0.0-m1.>
 > Release 
Notes:  https://github.com/asifdxtreme/incubator-servicecomb-service-center/blob/master/docs/releaseNotes.md  > 

 > Release 
Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/incubator-servicecomb-service-center/1.0.0-m1/   > 

 > Release 
Tag: https://github.com/apache/incubator-servicecomb-service-center/releases/tag/1.0.0-m1   > 

 > Release CommitId: 833b19c5d2ff7794b300284194121ebcb33ba8d8  >
 >
 > Keys to Verify the Release 
Candidate: https://dist.apache.org/repos/dist/dev/incubator/servicecomb/KEYS  > 

 >
 > Voting will start now (Monday, 19th Feburary, 2018) and will remain 
open for next 72 hours, Request all PPMC members to give their vote.>
 >
 > [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do 
not release this package because....>
 >
 >
 >
 > With Regards  Mohammad Asif Siddiqui>

Re: [VOTE] Release Apache ServiceComb Service-Center (incubating)version 1.0.0-m1

[Willem Jiang <wi...@gmail.com>]

-1,

Here are the issues that I found in this release candidate, I think we need
to fix them before release.

1. The binary files and source file doesn't have the apache-incubator
prefix.
2. I just used the rat tool[1] to check the License header issue and found
there are some go files and script files have no license header.
3. ServiceCenter supports to run with the embedded etcd, but the README
doesn't mention it.
4. There is no document for starting and stop the
frontend-servicecomb-service-center.

For the other parts, it looks good.
The key sign is checked, the binary file and source file has the License
and Notice file.
License and Notice files includes the third party dependencies.
Readme includes how to run the service center and build the binary from
source code.

[1]https://creadur.apache.org/rat/apache-rat/index.html


Willem Jiang

Blog: http://willemjiang.blogspot.com (English)
          http://jnn.iteye.com  (Chinese)
Twitter: willemjiang
Weibo: 姜宁willem

On Thu, Feb 22, 2018 at 9:46 AM, Sure <su...@qq.com> wrote:

> +1
>
>
> All tests are passed
>
> ------------------ Original ------------------
> From: preethi <ka...@gmail.com>
> Date: Tue,Feb 20,2018 2:14 PM
> To: dev <de...@servicecomb.apache.org>
> Subject: Re: [VOTE] Release Apache ServiceComb Service-Center
> (incubating)version 1.0.0-m1
>
>
>
> +1 Verified build from source on both Linux and windows
>
> On 2018/02/19 10:07:00, Mohammad Asif Siddiqui wrote:
>  > Hi All,>
>  > This is a call for vote to release ServiceComb Service-Center
> (Incubating)  version 1.0.0-m1.>
>  > Release
> Notes:  https://github.com/asifdxtreme/incubator-
> servicecomb-service-center/blob/master/docs/releaseNotes.md  >
>
>  > Release
> Candidate: https://dist.apache.org/repos/dist/dev/incubator/
> servicecomb/incubator-servicecomb-service-center/1.0.0-m1/   >
>
>  > Release
> Tag: https://github.com/apache/incubator-servicecomb-service-
> center/releases/tag/1.0.0-m1   >
>
>  > Release CommitId: 833b19c5d2ff7794b300284194121ebcb33ba8d8  >
>  >
>  > Keys to Verify the Release
> Candidate: https://dist.apache.org/repos/dist/dev/incubator/
> servicecomb/KEYS  >
>
>  >
>  > Voting will start now (Monday, 19th Feburary, 2018) and will remain
> open for next 72 hours, Request all PPMC members to give their vote.>
>  >
>  > [ ] +1 Release this package as 1.0.0-m1. [ ] +0 No opinion.[ ] -1 Do
> not release this package because....>
>  >
>  >
>  >
>  > With Regards  Mohammad Asif Siddiqui>
>