You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "taylorfinnell (via GitHub)" <gi...@apache.org> on 2023/02/28 00:38:52 UTC

[GitHub] [airflow] taylorfinnell opened a new issue, #29795: Can't use custom timetable

taylorfinnell opened a new issue, #29795:
URL: https://github.com/apache/airflow/issues/29795

   ### Apache Airflow version
   
   2.5.1
   
   ### What happened
   
   When implementing a custom timetable which is based on the included `workday` timetable I get runtime errors.
   
   `ValueError: Not a valid timetable`
   
   ```/opt/app-root/lib64/python3.8/site-packages/airflow/utils/session.py:75: in wrapper
       return func(*args, session=session, **kwargs)
   tests/helpers.py:34: in run_dag
       dag.test(
   /opt/app-root/lib64/python3.8/site-packages/airflow/utils/session.py:75: in wrapper
       return func(*args, session=session, **kwargs)
   /opt/app-root/lib64/python3.8/site-packages/airflow/models/dag.py:2518: in test
       dr: DagRun = _get_or_create_dagrun(
   /opt/app-root/lib64/python3.8/site-packages/airflow/models/dag.py:3676: in _get_or_create_dagrun
       dr = dag.create_dagrun(
   /opt/app-root/lib64/python3.8/site-packages/airflow/utils/session.py:72: in wrapper
       return func(*args, **kwargs)
   /opt/app-root/lib64/python3.8/site-packages/airflow/models/dag.py:2587: in create_dagrun
       data_interval = self.infer_automated_data_interval(logical_date)```
   
   My understanding is that `infer_automated_data_interval` should never be used or called when a custom timetable is being used.
   
   My custom timetable implements only the following methods:
   
   `infer_manual_data_interval` and `next_dagrun_info`.
   
   ### What you think should happen instead
   
   Custom timetable should allow scheduling
   
   ### How to reproduce
   
   I believe this issue will happen when using the built in `workday` timetable in the examples
   
   ### Operating System
   
   Centos 7
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Other
   
   ### Deployment details
   
   _No response_
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk closed issue #29795: Can't use custom timetable

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #29795: Can't use custom timetable
URL: https://github.com/apache/airflow/issues/29795


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] taylorfinnell commented on issue #29795: Can't use custom timetable

Posted by "taylorfinnell (via GitHub)" <gi...@apache.org>.
taylorfinnell commented on issue #29795:
URL: https://github.com/apache/airflow/issues/29795#issuecomment-1447391593

   Ah, this might be because I was using `DAG#test`, seems to work as a BackfillJob


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #29795: Can't use custom timetable

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on issue #29795:
URL: https://github.com/apache/airflow/issues/29795#issuecomment-1447345978

   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org