You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/07/22 16:53:20 UTC
[GitHub] [ignite] zstan opened a new pull request #8072: IGNITE-13289 Fix failure of PagesWriteThrottleSmokeTest.testThrottle
zstan opened a new pull request #8072:
URL: https://github.com/apache/ignite/pull/8072
Thank you for submitting the pull request to the Apache Ignite.
In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:
### The Contribution Checklist
- [ ] There is a single JIRA ticket related to the pull request.
- [ ] The web-link to the pull request is attached to the JIRA ticket.
- [ ] The JIRA ticket has the _Patch Available_ state.
- [ ] The pull request body describes changes that have been made.
The description explains _WHAT_ and _WHY_ was made instead of _HOW_.
- [ ] The pull request title is treated as the final commit message.
The following pattern must be used: `IGNITE-XXXX Change summary` where `XXXX` - number of JIRA issue.
- [ ] A reviewer has been mentioned through the JIRA comments
(see [the Maintainers list](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute#HowtoContribute-ReviewProcessandMaintainers))
- [ ] The pull request has been checked by the Teamcity Bot and
the `green visa` attached to the JIRA ticket (see [TC.Bot: Check PR](https://mtcga.gridgain.com/prs.html))
### Notes
- [How to Contribute](https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute)
- [Coding abbreviation rules](https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules)
- [Coding Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines)
- [Apache Ignite Teamcity Bot](https://cwiki.apache.org/confluence/display/IGNITE/Apache+Ignite+Teamcity+Bot)
If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com _#ignite_ channel.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] alex-plekhanov commented on a change in pull request #8072: IGNITE-13289 Fix failure of PagesWriteThrottleSmokeTest.testThrottle
Posted by GitBox <gi...@apache.org>.
alex-plekhanov commented on a change in pull request #8072:
URL: https://github.com/apache/ignite/pull/8072#discussion_r459512951
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java
##########
@@ -4270,6 +4270,8 @@ private long updateLastCheckpointTime() {
*/
private void markCheckpointEnd(Checkpoint chp) throws IgniteCheckedException {
synchronized (this) {
+ getCheckpointer().currentProgress().clearCounters();
Review comment:
Perhaps it's better to use `chp.progress` here, since it's for sure related to the finished checkpoint.
Currently, there can be only one checkpoint at a time and it's not an issue, but there was a plans to merge checkpoints (see https://issues.apache.org/jira/browse/IGNITE-10508)
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/checkpoint/CheckpointProgressImpl.java
##########
@@ -272,6 +272,15 @@ public void nextSnapshot(boolean nextSnapshot) {
evictedPagesCntr = new AtomicInteger();
}
+ /** {@inheritDoc} */
+ @Override public void clearCounters() {
+ currCheckpointPagesCnt = 0;
Review comment:
Perhaps it's better to set `currCheckpointPagesCnt` after all other counters, to keep invariant `total pages` >= `written pages` for example. But it's not an issue and it's up to you.
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/checkpoint/CheckpointProgress.java
##########
@@ -109,6 +109,9 @@
*/
public void updateEvictedPages(int deltha);
+ /** Clear cp progress counters */
Review comment:
Point at the end of line
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] zstan commented on a change in pull request #8072: IGNITE-13289 Fix failure of PagesWriteThrottleSmokeTest.testThrottle
Posted by GitBox <gi...@apache.org>.
zstan commented on a change in pull request #8072:
URL: https://github.com/apache/ignite/pull/8072#discussion_r459662497
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/GridCacheDatabaseSharedManager.java
##########
@@ -4270,6 +4270,8 @@ private long updateLastCheckpointTime() {
*/
private void markCheckpointEnd(Checkpoint chp) throws IgniteCheckedException {
synchronized (this) {
+ getCheckpointer().currentProgress().clearCounters();
Review comment:
Uff, i know about mentioned ticket, it looks like huge and controversial, but ok, i agree to change it, just because now it looks strange :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [ignite] asfgit closed pull request #8072: IGNITE-13289 Fix failure of PagesWriteThrottleSmokeTest.testThrottle
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #8072:
URL: https://github.com/apache/ignite/pull/8072
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org