[GitHub] [hive] aturoczy commented on a diff in pull request #4307: count(*) should be using Iceberg basic stats if present

["aturoczy (via GitHub)" <gi...@apache.org>]

aturoczy commented on code in PR #4307:
URL: https://github.com/apache/hive/pull/4307#discussion_r1190130567


##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java:
##########
@@ -299,7 +299,8 @@ public Object process(Node nd, Stack<Node> stack, NodeProcessorCtx procCtx,
           Logger.info("Table " + tbl.getTableName() + " is external. Skip StatsOptimizer.");
           return null;
         }
-        if (MetaStoreUtils.isNonNativeTable(tbl.getTTable())) {
+        if (MetaStoreUtils.isNonNativeTable(tbl.getTTable())

Review Comment:
   Please forgive the dumb question but in this case the isNonNativatTable could be anything else then Iceberg table?  Also  it would means the nonNative is those who has basicStats. Would not be better to have an util method IsIcebergTable(Table tbl) and inside the method check if it has basic stats. Outside of method to check is bit misleading  , but of course I do not know the full context. 
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org