[GitHub] [mina-sshd] lgoldstein commented on pull request #185: [SSHD-1141] Tolerate SSH_MSG_USERAUTH_PK_OK with wrong algorithm

[GitBox <gi...@apache.org>]

lgoldstein commented on pull request #185:
URL: https://github.com/apache/mina-sshd/pull/185#issuecomment-812359568


   Hi @tomaswolf , thanks for the great work. I do have one minor request - before merging into `master` please run a **full** `mvn clean install` - this is required due to the fact that during the build process the sources may be (re-)formatted, which might change them. We need to make sure that if someone pulls the code and compiles it, the `git status` command will not show any changes to our committed files. In this case, there were 2 files that were not properly formatted and they turned out when I was working on some issue and built the code - I was surprised to see 2 extra files that I have not touched marked as modified.
   
   Again, no real harm - but let's try and avoid these potential pitfalls.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org