You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/10/27 08:07:05 UTC

[GitHub] [iotdb] SteveYurongSu opened a new pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

SteveYurongSu opened a new pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243


   See IOTDB-1620 for more detail.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-953654399


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL)
   
   [![5.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '5.7%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_coverage&view=list) [5.7% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-952693038


   
   [![Coverage Status](https://coveralls.io/builds/43834866/badge)](https://coveralls.io/builds/43834866)
   
   Coverage increased (+0.08%) to 66.999% when pulling **9ffd4724cb83d9add82d9091a92c497a1e8f639a on iotdb-1620** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-952693038


   
   [![Coverage Status](https://coveralls.io/builds/43815663/badge)](https://coveralls.io/builds/43815663)
   
   Coverage increased (+0.08%) to 66.996% when pulling **21de4ab5191e9c8ea311a38624c461f280091e1b on iotdb-1620** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-952693038


   
   [![Coverage Status](https://coveralls.io/builds/43836705/badge)](https://coveralls.io/builds/43836705)
   
   Coverage increased (+0.08%) to 67.004% when pulling **7c06c7952b544ed8934e9c325d5b5318b07f7008 on iotdb-1620** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-952693038


   
   [![Coverage Status](https://coveralls.io/builds/43830867/badge)](https://coveralls.io/builds/43830867)
   
   Coverage decreased (-0.009%) to 66.912% when pulling **7fec7d2500388306275d0b373e55665b363251c8 on iotdb-1620** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-952693038


   
   [![Coverage Status](https://coveralls.io/builds/43863891/badge)](https://coveralls.io/builds/43863891)
   
   Coverage increased (+0.08%) to 67.003% when pulling **34b4221a7e745ef18d77ce04536d32901301f6fb on iotdb-1620** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-952693038


   
   [![Coverage Status](https://coveralls.io/builds/43830476/badge)](https://coveralls.io/builds/43830476)
   
   Coverage increased (+0.09%) to 67.015% when pulling **7fec7d2500388306275d0b373e55665b363251c8 on iotdb-1620** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on a change in pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#discussion_r738901923



##########
File path: antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlParser.g4
##########
@@ -680,8 +677,7 @@ wildcard
     ;
 
 literalCanBeNodeName
-    : QUOTED_STRING_LITERAL
-    | datetimeLiteral
+    : datetimeLiteral
     | DURATION_LITERAL
     | (MINUS|PLUS)? INTEGER_LITERAL

Review comment:
       I modified the g4 file, please take a look again. :D




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-954409453


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL)
   
   [![5.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '5.7%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_coverage&view=list) [5.7% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] commented on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-953587631


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL)
   
   [![5.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '5.7%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_coverage&view=list) [5.7% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-952693038


   
   [![Coverage Status](https://coveralls.io/builds/43834275/badge)](https://coveralls.io/builds/43834275)
   
   Coverage increased (+0.1%) to 67.034% when pulling **9ffd4724cb83d9add82d9091a92c497a1e8f639a on iotdb-1620** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-952693038


   
   [![Coverage Status](https://coveralls.io/builds/43805116/badge)](https://coveralls.io/builds/43805116)
   
   Coverage increased (+0.1%) to 67.059% when pulling **aa30e60bea9cb36b76c5c643acf8e141982e8604 on iotdb-1620** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on a change in pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
cornmonster commented on a change in pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#discussion_r738265807



##########
File path: antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlParser.g4
##########
@@ -680,8 +677,7 @@ wildcard
     ;
 
 literalCanBeNodeName
-    : QUOTED_STRING_LITERAL
-    | datetimeLiteral
+    : datetimeLiteral
     | DURATION_LITERAL
     | (MINUS|PLUS)? INTEGER_LITERAL

Review comment:
       This rule also introduces ambiguities.

##########
File path: antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlParser.g4
##########
@@ -680,8 +677,7 @@ wildcard
     ;
 
 literalCanBeNodeName
-    : QUOTED_STRING_LITERAL
-    | datetimeLiteral
+    : datetimeLiteral
     | DURATION_LITERAL
     | (MINUS|PLUS)? INTEGER_LITERAL

Review comment:
       This rule also introduces ambiguities.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-953587631


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL)
   
   [![5.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '5.7%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_coverage&view=list) [5.7% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu commented on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-954350443


   @liuminghui233 PTAL :D


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on a change in pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
cornmonster commented on a change in pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#discussion_r738250381



##########
File path: antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlLexer.g4
##########
@@ -913,43 +897,23 @@ NAN_LITERAL
  */
 
 ID
-    : FIRST_NAME_CHAR NAME_CHAR*
+    : NAME_CHAR+

Review comment:
       I am working on this issue: https://issues.apache.org/jira/browse/IOTDB-1886
   
   To support something like "SELECT 1 + s1 FROM root.sg.d1", we should not allow intergers to be identifiers. 
   
   Here is what I did: https://github.com/apache/iotdb/pull/4257




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on a change in pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
cornmonster commented on a change in pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#discussion_r739003698



##########
File path: antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlParser.g4
##########
@@ -662,41 +661,17 @@ suffixPath
 nodeName
     : wildcard? ID wildcard?

Review comment:
       it seems queries like "SELECT s* FROM root.sg.d1" works, but "SELECT \`s\`* FROM root.sg.d1" doesn't




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-952693038


   
   [![Coverage Status](https://coveralls.io/builds/43814935/badge)](https://coveralls.io/builds/43814935)
   
   Coverage increased (+0.08%) to 66.997% when pulling **21de4ab5191e9c8ea311a38624c461f280091e1b on iotdb-1620** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-952693038


   
   [![Coverage Status](https://coveralls.io/builds/43804103/badge)](https://coveralls.io/builds/43804103)
   
   Coverage decreased (-0.006%) to 66.914% when pulling **aa30e60bea9cb36b76c5c643acf8e141982e8604 on iotdb-1620** into **a8d9e4b5d7bd4deb42785612f8e5880eab22f398 on master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on a change in pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
cornmonster commented on a change in pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#discussion_r739003698



##########
File path: antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlParser.g4
##########
@@ -662,41 +661,17 @@ suffixPath
 nodeName
     : wildcard? ID wildcard?

Review comment:
       it seems queries like "SELECT s* FROM root.sg.d1" works, but "SELECT `s`* FROM root.sg.d1" doesn't




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] sonarcloud[bot] removed a comment on pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] removed a comment on pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243#issuecomment-953654399


   SonarCloud Quality Gate failed.&nbsp; &nbsp; ![Quality Gate failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/failed-16px.png 'Quality Gate failed')
   
   [![Bug](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/bug-16px.png 'Bug')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=BUG)  
   [![Vulnerability](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/vulnerability-16px.png 'Vulnerability')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=VULNERABILITY)  
   [![Security Hotspot](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/security_hotspot-16px.png 'Security Hotspot')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=SECURITY_HOTSPOT)  
   [![Code Smell](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/code_smell-16px.png 'Code Smell')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL) [![A](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/RatingBadge/A-16px.png 'A')](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL) [2 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=4243&resolved=false&types=CODE_SMELL)
   
   [![5.7%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/CoverageChart/0-16px.png '5.7%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_coverage&view=list) [5.7% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_coverage&view=list)  
   [![0.0%](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/Duplications/3-16px.png '0.0%')](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=4243&metric=new_duplicated_lines_density&view=list)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] JackieTien97 merged pull request #4243: [IOTDB-1620] Support backtick (`) character and double quotes (") to quote identifiers

Posted by GitBox <gi...@apache.org>.
JackieTien97 merged pull request #4243:
URL: https://github.com/apache/iotdb/pull/4243


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org