[GitHub] [ozone] sodonnel commented on pull request #3668: HDDS-7022. EC: Open EC container are not closed when SCM container was already closed.

[GitBox <gi...@apache.org>]

sodonnel commented on PR #3668:
URL: https://github.com/apache/ozone/pull/3668#issuecomment-1223117285

   We probably should have added a unit test for this change in TestReplicationManager, similar to testUnhealthyOpenContainerClosed. All the logic in the new RM code has quite clean unit tests so far.
   
   Also, I believe this new logic should either have gone into the ECContainerHealthyCheck class, or we should have created a new "CommonHealthCheck" class, that gets called for both Ratis and EC containers. We are trying to avoid the main RM class taking on too many roles by splitting the business logic out into the separate check classes. The logic in the `if (containerInfo.getState() == HddsProtos.LifeCycleState.OPEN)` block should probably be in the same common class too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org