[GitHub] [pinot] KKcorps commented on pull request #10562: [feature] [null support # 5] Support null in scalar transform function wrapper

["KKcorps (via GitHub)" <gi...@apache.org>]

KKcorps commented on PR #10562:
URL: https://github.com/apache/pinot/pull/10562#issuecomment-1504680000

   We earlier added `nullableParameters = true` in ScalarFunction annotation. IMO, we should also remove that since all functions can now support null. This is only used internally in the codebase so shouldn't be an issue.
   
   We do need to make sure the methods which uses this flag though work correctly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org